Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[entity_resolution] Not error when optional properties are not present in entity #138

Merged

Conversation

varshaprasad96
Copy link
Member

@varshaprasad96 varshaprasad96 commented Mar 22, 2023

This PR introduces the optional field while loading entities from bundles. If the property is optional and is not present, we do not error.

Fixes: #123

…tity

This PR introduces the optional field while loading entities from bundles.
If the property is optional and is not present, we do not error.

Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
@varshaprasad96 varshaprasad96 changed the title [entity] Not error when optional properties are not present in entity [entity_resolution] Not error when optional properties are not present in entity Mar 22, 2023
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @varshaprasad96!

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2023
@varshaprasad96 varshaprasad96 merged commit f4b4bba into operator-framework:main Mar 23, 2023
@varshaprasad96 varshaprasad96 deleted the load-from-entity branch March 23, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The resolver should treat certain properties/constraints as optional
2 participants