Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump goreleaser, remove obsolete substitute task #147

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

joelanford
Copy link
Member

@joelanford joelanford commented Mar 30, 2023

Go releaser 1.16.1 made it possible to use templates in the release.disable and changelog.skip fields. As a result, we can simplify our release process by directly templating our release pipeline environment variable into the goreleaser config file.

This means we can completely remove our make substitute target.

I also changed the polarity of the DISABLE_RELEASE_PIPELINE ?= true environment variable to be ENABLE_RELEASE_PIPELINE ?= false. This seemed more intuitive (to me at least).

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Copy link
Member

@awgreene awgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

/approve

@joelanford joelanford merged commit 4d6757a into operator-framework:main Mar 30, 2023
@joelanford joelanford deleted the goreleaser-bump branch August 29, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants