Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce CODEOWNERS #155

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Conversation

awgreene
Copy link
Member

@awgreene awgreene commented Apr 4, 2023

Learn more about CODEOWNERS here, or look at this description below:

Code owners are automatically requested for review when someone opens a pull request that modifies code that they own. Code owners are not automatically requested to review draft pull requests. For more information about draft pull requests, see "About pull requests." When you mark a draft pull request as ready for review, code owners are automatically notified. If you convert a pull request to a draft, people who are already subscribed to notifications are not automatically unsubscribed. For more information, see "Changing the stage of a pull request."

When someone with admin or owner permissions has enabled required reviews, they also can optionally require approval from a code owner before the author can merge a pull request in the repository. For more information, see "About protected branches."

Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
@dtfranz
Copy link
Contributor

dtfranz commented Apr 10, 2023

I noticed the description of the operator-framework/operator-controller-maintainers group is "non Red Hat operator-controller-maintainers" yet it's currently populated only with Red Hat people. That isn't the case for the other projects though e.g. deppy+rukpak's equivalent groups are non Red Hat only. Any reason it's set up that way?

@tmshort
Copy link
Contributor

tmshort commented Apr 11, 2023

I agree with @dtfranz that the current list seems somewhat limiting.

@tmshort
Copy link
Contributor

tmshort commented Apr 19, 2023

Is there any reason not to approve this? Or do we want to update the list of OWNERS first?

@tmshort
Copy link
Contributor

tmshort commented May 23, 2023

Bueller?

Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@perdasilva perdasilva merged commit ea04175 into operator-framework:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants