Release Install script #157
Conversation
| @@ -0,0 +1,45 @@ | |||
| #!/bin/bash | |||
|
|
|||
| olm_version=$OLM_V0_VERSION | |||
There was a problem hiding this comment.
These are "supposed" to be set from the envsubst command in the makefile's quickstart target but I added some simple checks just in case.
scripts/install.tpl.sh
Outdated
| kubectl_wait "rukpak-system" "deployment/helm-provisioner" "60s" | ||
| kubectl_wait "rukpak-system" "deployment/rukpak-webhooks" "60s" | ||
|
|
||
| kubectl apply -f "https://github.com/operator-framework/operator-controller/releases/download/${operator_controller_version}/operator-controller.yaml" |
There was a problem hiding this comment.
One thing that could be useful here is if we used this install script as part of the e2e and run targets. That way we actually exercise this as part of our dev cycle and testing.
I think all we would need to do is make the entire operator-controller manifest path configurable.
For make run, we'd generate the manifest without the image ref substitution, and then this would be kubectl apply -f ./operator-controller.yaml
For the release manifest, we'd substitute the entire release URL in like you're doing here.
If this is not a trivial change, its totally non-blocking and would be fine to do in a follow-up.
There was a problem hiding this comment.
FWIW, I did this in the taskfile PR, so you may be able to crib from that.
https://github.com/joelanford/operator-controller/blob/taskfile/.taskfile.build.yaml#L72-L116
There was a problem hiding this comment.
Cool! I'll give this a shot, it's a good idea.
Adds an install script which installs the required sub-components of OLM v1 in a single command. The install script is built on-the-fly when the release is run, and the appropriate versions of all sub-components are set inside the Makefile or grabbed from the go.mod file. Signed-off-by: dtfranz <dfranz@redhat.com>
Adds an install script which installs the required sub-components of OLM v1 in a single command. The install script is built on-the-fly when the release is run, and the appropriate versions of all sub-components are set inside the Makefile or grabbed from the go.mod file.
Addresses #110