Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: don't globally export GOOS=linux #221

Merged
merged 1 commit into from
May 18, 2023

Conversation

joelanford
Copy link
Member

Description

Fixes #220

Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with one minor question.

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@tmshort
Copy link
Contributor

tmshort commented May 18, 2023

Still looks good, waiting for CI

@joelanford joelanford merged commit 6700914 into operator-framework:main May 18, 2023
@joelanford joelanford deleted the fix-goos-export branch May 18, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'go run' uses GOOS=linux for local tools, even on non-linux platforms
2 participants