Removes util package

[m1kola]

Description

util is too generic for a package name.

Let's try and avoid packages like utils, common, etc as packages like this tend to become dumping grounds.

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[tmshort]

I'm going to whine about the length of the name (conditionsets vs util), perhaps abbreviate (within the code, not necessarily the directory name) to cond?

[m1kola]

@tmshort previously it was imported as operatorutil which is 1 char longer than conditionsets. I would prefer conditionsets over cond as it is less ambiguous. But yeah...

There are only two hard things in Computer Science: cache invalidation and naming things.

😄

[tmshort]

I meant in the code - not the directory name. I don't think conditionsets.ConditionType is any clearer than cond.ConditionType. shrug

[m1kola]

@tmshort I was consindering calling it cond or condition, but this is not about condition itself. I don't know how to make it clear that this is not about condition but rather about a set/collection of condition types. And at the same time not introduce confusion with API package and other common abbreviations.

Overall - I don't like this thing. Especially the fact that we tightly coupled API (api/v1alpha1/operator_types.go) with an utility package which only used for tests.

[tmshort]

ping @m1kola for rebase?

[m1kola]

@tmshort rebased. Please take another look.