refactor e2e for speed and clarity, add helpers #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
commented
Jun 1, 2023
Comment on lines
+124
to
+132
| var conditions []metav1.Condition | ||
| switch v := obj.(type) { | ||
| case *catalogd.Catalog: | ||
| conditions = v.Status.Conditions | ||
| case *operatorv1alpha1.Operator: | ||
| conditions = v.Status.Conditions | ||
| default: | ||
| return StopTrying(fmt.Sprintf("cannot get conditions for unknown object type %T", obj)) | ||
| } |
There was a problem hiding this comment.
An earlier iteration of this section of code called a separate function I had written that generically:
- converted to unstructured
- extracted "status.conditions" into
[]interface{} - marshaled that to JSON
- unmarshaled the JSON into []metav1.Condition
That code generically handled anything that had status.conditions with type []metav1.Condition, but it seemed a bit hacky/overkill. I'm happy to go back to that, or entertain other options as well.
everettraven
approved these changes
Jun 1, 2023
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the install e2e test by:
Eventuallyblocks now fail early if unexpected failures occur, which makes e2e runs fail faster rather than being required to wait the fullEventuallytimeout.This should mostly eliminate the flakes related to catalog processing mentioned in #215.
Reviewer Checklist