Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing ginkgo test with go testing #248

Closed
wants to merge 8 commits into from
Closed

Replacing ginkgo test with go testing #248

wants to merge 8 commits into from
+103 −102

Commits on Jun 8, 2023

  1. Replacing ginkgo test with go testing 

    Signed-off-by: jubittajohn <jujohn@redhat.com>
    @jubittajohn
    jubittajohn committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    6353e18 View commit details
    Browse the repository at this point in the history

  2. Fix formatting 

    Signed-off-by: jubittajohn <jujohn@redhat.com>
    @jubittajohn
    jubittajohn committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    a74f229 View commit details
    Browse the repository at this point in the history

  3. Modify expected solution to utilize arguments 

    Signed-off-by: jubittajohn <jujohn@redhat.com>
    @jubittajohn
    jubittajohn committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    e6dc77b View commit details
    Browse the repository at this point in the history

  4. Replace predefined selected variable count with len function 

    Signed-off-by: jubittajohn <jujohn@redhat.com>
    @jubittajohn
    jubittajohn committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    0e59413 View commit details
    Browse the repository at this point in the history

  5. Change error condition check to use expected error 

    Signed-off-by: jubittajohn <jujohn@redhat.com>
    @jubittajohn
    jubittajohn committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    ad62fe9 View commit details
    Browse the repository at this point in the history

  6. Replace the actual production image with a sample image path and appl… 

    …y minor changes

Signed-off-by: jubittajohn <jujohn@redhat.com>
    @jubittajohn
    jubittajohn committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    fe19ce1 View commit details
    Browse the repository at this point in the history

  7. Remove olm.gvk property 

    Signed-off-by: jubittajohn <jujohn@redhat.com>
    @jubittajohn
    jubittajohn committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    a496d68 View commit details
    Browse the repository at this point in the history

  8. Change test file to make OLMVariableSource responsible for fetching 

    Signed-off-by: jubittajohn <jujohn@redhat.com>
    @jubittajohn
    jubittajohn committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    1337fca View commit details
    Browse the repository at this point in the history