Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(e2e) Use custom built test catalog for e2e testing #250

Merged
merged 1 commit into from
Jun 5, 2023
Merged

(e2e) Use custom built test catalog for e2e testing #250

merged 1 commit into from
Jun 5, 2023

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented Jun 2, 2023

This PR

  • Stands up a local image registry in the cluster

  • Builds bundles and catalog images and uploads them to the image registry

  • Uses the custom images in the e2e test suite

  • Also introduces a pullSecret field for the Operator API's Spec struct, to allow installation of operators on cluster whose bundles require imagePullSecret to be provisioned. This is required because the bundle images built and uploaded to the local registry above requires a pull secret for the local registry.

closes #215

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@anik120 anik120 requested review from joelanford, dtfranz and tmshort June 2, 2023 13:11
@joelanford
Copy link
Member

  • Stands up a local image registry in the cluster
  • Builds bundles and catalog images and uploads them to the image registry

I think this is overkill. We should be able to simply build the images, kind load them, and then refer to them directly in the e2e. No need to run an extra image registry, IMO.

@joelanford
Copy link
Member

I think we should emulate the way rukpak set this up:
Build and load here: https://github.com/operator-framework/rukpak/blob/fdc3ebd85c928072fc6f6b59a2debf752159b791/Makefile#L185

Directly refer to those image in e2e's. For example: https://github.com/operator-framework/rukpak/blob/fdc3ebd85c928072fc6f6b59a2debf752159b791/test/e2e/plain_provisioner_test.go#L71

@everettraven
Copy link
Contributor

Stands up a local image registry in the cluster

This feels very heavy handed - is there a reason we have to stand up an image registry on cluster instead of just kind loading the images? As long as we aren't using images with :latest tags the default Kube pull policy should just allow us to use kind load to load images and use them with the unpack pods.

In my head the most simple and straightforward approach to using a custom built test catalog would be to:

  1. Build a custom test catalog & pull the bundle image, tagging with a non :latest tag
    2 kind load docker-image ... for both images from 1
  2. Change the catalog image in the e2e tests
  3. Run the e2e tests

@anik120
Copy link
Contributor Author

anik120 commented Jun 2, 2023

Looks like my use of the latest tag was in fact the problem.

:latest tags the default Kube pull policy

TIL.

Updated the PR to just use built and loaded images

@anik120 anik120 force-pushed the test-catalog branch 2 times, most recently from ae4519e to 0532f43 Compare June 2, 2023 14:34
everettraven
everettraven requested changes Jun 2, 2023
View reviewed changes
Makefile Show resolved Hide resolved
testdata/catalogs/test-catalog/catalog.yaml Outdated Show resolved Hide resolved
testdata/catalogs/test-catalog/catalog.yaml Outdated Show resolved Hide resolved
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2023
everettraven
everettraven approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, only have a question about the related images in the bundle blob

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2023
@anik120
Copy link
Contributor Author

anik120 commented Jun 2, 2023

Overall looks good to me, only have a question about the related images in the bundle blob

Removed the related images, they aren't needed 👍🏽

@anik120
Copy link
Contributor Author

anik120 commented Jun 2, 2023

/hold

looks like the e2e tests are failing after rebasing on top of #216, have to investigate it

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2023
joelanford
joelanford reviewed Jun 2, 2023
View reviewed changes
testdata/catalogs/test-catalog/catalog.yaml Outdated
{
"schema": "olm.package",
"name": "prometheus",
"defaultChannel": "beta"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to remove this line as well based on my other comment, but I think catalogd may validate the input (and removing this line would cause that validation to fail)

Maybe add a TODO comment to this line that we're only setting this to satisfy the existing OLMv0-based validation logic and that we should look for a way to be able to remove this. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like adding comments to a json file isn't that easy.
One way would be to add a key/value of the form "comment": "TODO:...", but that's possibly a bit confusing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, forgot about that. Let's just leave it as is.

@anik120 anik120 force-pushed the test-catalog branch 2 times, most recently from dd41d0b to 2609831 Compare June 2, 2023 19:39
@anik120
Copy link
Contributor Author

anik120 commented Jun 2, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2023
@everettraven everettraven self-requested a review June 2, 2023 20:09
everettraven added a commit to everettraven/operator-controller that referenced this pull request Jun 2, 2023
@everettraven
rebase on an early commit of operator-framework#250 and implement e2e…
a49efb5 
… tests

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
everettraven added a commit to everettraven/operator-controller that referenced this pull request Jun 2, 2023
@everettraven
rebase on an early commit of operator-framework#250 and implement e2e…
771b5f8 
… tests

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
everettraven
everettraven approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this seems fine for now. There is likely going to be some modifications as part of #242

joelanford
joelanford reviewed Jun 2, 2023
View reviewed changes
testdata/catalogs/test-catalog/catalog.json
Comment on lines +30 to +32
"relatedImages": [
{}
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: remove "relatedImages" entirely?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like spec.relatedImages field is not optional:

condition "Unpacked" is False/UnpackFailed; message: "create bundle metadata objects: applying bundle metadata \"test-catalog-prometheusoperator.0.47.0\": BundleMetadata.catalogd.operatorframework.io \"test-catalog-prometheusoperator.0.47.0\" is invalid: spec.relatedImages: Invalid value: \"null\": spec.relatedImages in body must be of type array: \"null\""

Admittedly I'd have preferred to keep it at "relatedImages": [] but even that is read as null, and had to do some json jujitsu to come up with [{}]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ Shouldn't be an issue after operator-framework/catalogd#38 is done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bug in catalogd. We should not require relatedImages to be populated. In fact, I would argue that [{}] is more invalid because it is saying "here's a related image. it's image is "" and it's name is "".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to create a follow up issue to fix this.

joelanford
joelanford reviewed Jun 2, 2023
View reviewed changes
test/e2e/install_test.go Outdated Show resolved Hide resolved
joelanford
joelanford reviewed Jun 2, 2023
View reviewed changes
test/e2e/install_test.go Outdated Show resolved Hide resolved
@anik120
(e2e) Use custom built test catalog for e2e testing
34bd607 
closes operator-framework#215

Signed-off-by: Anik <anikbhattacharya93@gmail.com>
joelanford
joelanford approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@joelanford joelanford merged commit 4391c50 into operator-framework:main Jun 5, 2023
everettraven added a commit to everettraven/operator-controller that referenced this pull request Jun 6, 2023
@everettraven
rebase on an early commit of operator-framework#250 and implement e2e…
fc7729e 
… tests

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
everettraven added a commit to everettraven/operator-controller that referenced this pull request Jun 6, 2023
@everettraven
rebase on an early commit of operator-framework#250 and implement e2e…
6034b41 
… tests

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
everettraven added a commit to everettraven/operator-controller that referenced this pull request Jun 6, 2023
@everettraven
rebase on an early commit of operator-framework#250 and implement e2e…
aedd8af 
… tests

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
everettraven added a commit to everettraven/operator-controller that referenced this pull request Jun 6, 2023
@everettraven
rebase on an early commit of operator-framework#250 and implement e2e…
f3ad11c 
… tests

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@anik120 anik120 mentioned this pull request Jun 6, 2023
Merged
4 tasks
This was referenced Jun 7, 2023
Closed
Closed
awgreene pushed a commit to awgreene/operator-controller that referenced this pull request Oct 13, 2023
@anik120 @joelanford
(e2e) Use custom built test catalog for e2e testing (operator-framewo…
17415ca 
…rk#250)
LalatenduMohanty pushed a commit to LalatenduMohanty/operator-controller that referenced this pull request Dec 19, 2024
@dependabot
🌱 Bump actions/setup-go from 4 to 5 (operator-framework#250)
94b0412 
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Jan 9, 2025
@camilamacedo86 @ncdc
@joelanford @rashmigottipati @anik120 @grokspawn @everettraven @oceanc80 @kevinrizza @dependabot @m1kola @trgeiger @tmshort @LalatenduMohanty @itroyano @ankitathomas @dtfranz @perdasilva @bentito @thetechnick
⚠️ [Monorepo] PHASE 1 - Add Catalogd to Operator-Controller Repository (
75bb73e 
#1542)

* Makes codecov-action optional

We do not want to fail the job if codecov fails
to upload the report due to rate limiting.

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>

* Enable dependabot (#125)

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>

* Enable merge queue (#131)

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>

* Switch to using tilt-support repo

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>

* Add DCO information

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>

* Add CI for tilt (#134)

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>

* Enable CatalogMetadataAPI via explicit flag, fix syncing issues (#138)

* Setup CODEOWNERS (#140)

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>

* Deprecate the `CatalogMetadataAPI` feature gate (#141)

Marking the CatalogMetadataAPI feature gate as Deprecated before introducing the HTTP server as a default mechanism to serve catalog contents

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>

* Remove Package and BundleMetadata APIs (#149)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

* add go-apidiff action (#151)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

* Store FBC in local directory (#144)

closes #113

Signed-off-by: Anik <anikbhattacharya93@gmail.com>

* update demo based on API changes (#154)

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

* Serve locally stored fbc content via an http server (#148)

Closes #113

Signed-off-by: Anik <anikbhattacharya93@gmail.com>

* Add metrics to the catalog server (#156)

* add metrics to catalogd http server

that can be used for calculating the Apdex Score
and assess the health of the http server that is
serving catalog contents to clients

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>

* quick fixes from review comments

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>

* rename package from server --> metrics

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>

* rename package from server --> metrics

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>

---------

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>

* (docs): Add docs on fetching contents via HTTP server (#166)

* (docs): Add docs on fetching contents via HTTP server

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>

* add curl examples

Signed-off-by: Bryce Palmer <everettraven@gmail.com>

---------

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <everettraven@gmail.com>

* (refactor): Remove deprecated CatalogMetadata and associated code (#169)

* (refactor): Remove deprecated CatalogMetadata and associated code

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>

* go mod tidy

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>

---------

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>

* (server) Expose content URL on CR status (#168)

closes #119

Signed-off-by: Anik <anikbhattacharya93@gmail.com>

* deps: bump kubernetes and operator-registry (#173)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

* Add RELEASING.md (#176)

Add release guide

Signed-off-by: Catherine Chan-Tse <cchantse@redhat.com>

* Add contribution guide  (#165)

* Add contributing guide to catalogd

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>

* Address review comments

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>

---------

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>

* Update README with simplified make target ref (#178)

Signed-off-by: kevinrizza <krizza@redhat.com>

* add default printer columns (#174)

Add default printer columns

Signed-off-by: kevinrizza <krizza@redhat.com>

* (cleanup) Kustomization (#183)

Closes #155, #160

Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>

* (feature): add direct image registry client `Unpacker` implementation (#145)

(feat): direct image registry client unpacker

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>

* (techdebt): refactor catalog controller unit tests (#196)

* (techdebt): refactor catalog controller unit tests

to no longer use Ginkgo and instead use
the native Go testing and testify

Signed-off-by: Bryce Palmer <everettraven@gmail.com>

* remove rebase detritus, unnecessary IIFE, and featuregate comments/blocks. goimports.

Signed-off-by: Bryce Palmer <everettraven@gmail.com>

---------

Signed-off-by: Bryce Palmer <everettraven@gmail.com>

* Bump golang.org/x/net from 0.10.0 to 0.17.0 (#197)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.10.0 to 0.17.0.
- [Commits](https://github.com/golang/net/compare/v0.10.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/docker/docker from 23.0.1+incompatible to 23.0.3+incompatible (#195)

Bump github.com/docker/docker

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 23.0.1+incompatible to 23.0.3+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](https://github.com/docker/docker/compare/v23.0.1...v23.0.3)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* (feature) Implement polling image source in intervals (#185)

Implements https://docs.google.com/document/d/1iWSrWL9pYRJ5Ua3VYErkK1Q2lAusBUeDCh66Ew4lDbQ/edit?usp=sharing

Closes #180

Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>

* Add GoDoc for Phase (#199)

GoDoc for Phase

Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>

* (feature): add skip-tls-verify option for image sources (#201)

* (feature): add skip-tls-verify option for image sources

Signed-off-by: Bryce Palmer <everettraven@gmail.com>

* re-generate manifests

Signed-off-by: Bryce Palmer <everettraven@gmail.com>

---------

Signed-off-by: Bryce Palmer <everettraven@gmail.com>

* 🌱 Add PR template with icons & verify job (#205)

Add PR template with icons & verify job

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>

* 🌱 Bump github.com/docker/docker from 23.0.3+incompatible to 24.0.7+incompatible (#203)

Bump github.com/docker/docker

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 23.0.3+incompatible to 24.0.7+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](https://github.com/docker/docker/compare/v23.0.3...v24.0.7)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :bug: attempt to remove cache entry if unpack fails (#207)

(bugfix): attempt to remove cache entry if unpack fails

and add a new test case that ensures if the required label
is missing from the image, thus failing image unpacking,
an error is consistently returned

fixes #206

Signed-off-by: Bryce Palmer <everettraven@gmail.com>

* 🌱 Prefix dependabot GH actions PRs (#208)

Prefix dependabot GH actions PRs

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>

* :seedling: replace e2e Job with client-go ProxyGet() call (#210)

(e2e): replace e2e Job with client-go ProxyGet() call

Signed-off-by: Bryce Palmer <everettraven@gmail.com>

* ✨ Add Ingress overlay to access `Catalog` contents outside of the cluster (#209)

* Add Ingress overlay to access `Catalog` contents outside of the cluster

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>

* Address review feedback

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>

* Address review feedback #1

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>

* Address feedback #2

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>

---------

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>

* 🌱 bump to k8s 1.27.7 (#211)

bump to k8s 1.27.7

to ensure catalogd is fully remediated and
unaffected by the rapid reset CVE

Signed-off-by: Bryce Palmer <everettraven@gmail.com>

* :seedling: Remove cert-manager from release note install process (#215)

Remove cert-manager from release note install process

as cert-manager has not been a requirement for installing
catalogd for quite some time.

Signed-off-by: Bryce Palmer <everettraven@gmail.com>

* :bug: Add enum validation for source type (#214)

Add enum validation for source type

Signed-off-by: Bryce Palmer <everettraven@gmail.com>

* 🌱  updates to enable autogenerated demo, hosted out-of-tree (#212)

* updates to support automated demo generation

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

* review updates

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

---------

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

* :seedling: demo install from published tag (#217)

* demo install from published tag

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

* review updates

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

---------

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

* Bump golang.org/x/crypto from 0.14.0 to 0.17.0 (#218)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.17.0.
- [Commits](https://github.com/golang/crypto/compare/v0.14.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/go-git/go-git/v5 from 5.4.2 to 5.11.0 (#220)

Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.4.2 to 5.11.0.
- [Release notes](https://github.com/go-git/go-git/releases)
- [Commits](https://github.com/go-git/go-git/compare/v5.4.2...v5.11.0)

---
updated-dependencies:
- dependency-name: github.com/go-git/go-git/v5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/containerd/containerd from 1.6.22 to 1.6.26 (#219)

Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.6.22 to 1.6.26.
- [Release notes](https://github.com/containerd/containerd/releases)
- [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md)
- [Commits](https://github.com/containerd/containerd/compare/v1.6.22...v1.6.26)

---
updated-dependencies:
- dependency-name: github.com/containerd/containerd
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* (bugfix): bump the catalogserver write timeout to 5 minutes (#223)

to allow for fully writing large catalogs contents
in the response

Signed-off-by: everettraven <everettraven@gmail.com>

* (bugfix): add validation for pollInterval duration units (#225)

Signed-off-by: everettraven <everettraven@gmail.com>

* (chore): bump supported k8s version to 1.28 (#227)

bumps controller-runtime --> v0.16.3
bumps k8s.io deps --> v0.28.5
bumps operator-registry --> v1.34.0
updated kind version --> v0.20.0
made kind node image configurable and 1.28 by default
updated ginkgo version --> v2.12.0

Signed-off-by: everettraven <everettraven@gmail.com>

* Bump github.com/containerd/containerd from 1.7.6 to 1.7.11 (#228)

Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.7.6 to 1.7.11.
- [Release notes](https://github.com/containerd/containerd/releases)
- [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md)
- [Commits](https://github.com/containerd/containerd/compare/v1.7.6...v1.7.11)

---
updated-dependencies:
- dependency-name: github.com/containerd/containerd
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump golang.org/x/crypto from 0.16.0 to 0.17.0 (#230)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.16.0 to 0.17.0.
- [Commits](https://github.com/golang/crypto/compare/v0.16.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* (bugfix): make garbage collection a runnable (#231)

and add it to the controller manager. Make it log errors instead of
exiting. This prevents crashlooping when there are errors in the
garbage collection process.

Signed-off-by: everettraven <everettraven@gmail.com>

* bumping codecov-action to v4 (#232)

* GH Actions: add workflow to add epic issues to OLMv1 project (#233)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

* Bump google.golang.org/protobuf from 1.31.0 to 1.33.0 (#234)

Bumps google.golang.org/protobuf from 1.31.0 to 1.33.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump Go to 1.21 (#237)

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>

* bump docker deps to 25.0.5 (#236)

* bump kind to 0.22.0 (#238)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

* remove terminating space in dependabot config file (#245)

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

* make golangci-lint config consistent across repos (#255)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

* Bump golang.org/x/net from 0.19.0 to 0.23.0 (#244)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.19.0 to 0.23.0.
- [Commits](https://github.com/golang/net/compare/v0.19.0...v0.23.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump docker/login-action from 2 to 3 (#246)

Bumps [docker/login-action](https://github.com/docker/login-action) from 2 to 3.
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](https://github.com/docker/login-action/compare/v2...v3)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump actions/checkout from 3 to 4 (#247)

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump github.com/go-logr/logr from 1.3.0 to 1.4.1 (#253)

Bumps [github.com/go-logr/logr](https://github.com/go-logr/logr) from 1.3.0 to 1.4.1.
- [Release notes](https://github.com/go-logr/logr/releases)
- [Changelog](https://github.com/go-logr/logr/blob/master/CHANGELOG.md)
- [Commits](https://github.com/go-logr/logr/compare/v1.3.0...v1.4.1)

---
updated-dependencies:
- dependency-name: github.com/go-logr/logr
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump actions/add-to-project from 0.5.0 to 1.0.1 (#249)

Bumps [actions/add-to-project](https://github.com/actions/add-to-project) from 0.5.0 to 1.0.1.
- [Release notes](https://github.com/actions/add-to-project/releases)
- [Commits](https://github.com/actions/add-to-project/compare/v0.5.0...v1.0.1)

---
updated-dependencies:
- dependency-name: actions/add-to-project
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump actions/setup-go from 4 to 5 (#250)

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump sigs.k8s.io/yaml from 1.3.0 to 1.4.0 (#254)

Bumps [sigs.k8s.io/yaml](https://github.com/kubernetes-sigs/yaml) from 1.3.0 to 1.4.0.
- [Release notes](https://github.com/kubernetes-sigs/yaml/releases)
- [Changelog](https://github.com/kubernetes-sigs/yaml/blob/master/RELEASE.md)
- [Commits](https://github.com/kubernetes-sigs/yaml/compare/v1.3.0...v1.4.0)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/yaml
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump kubernetes-sigs/kubebuilder-release-tools (#248)

Bumps [kubernetes-sigs/kubebuilder-release-tools](https://github.com/kubernetes-sigs/kubebuilder-release-tools) from 0.4.0 to 0.4.3.
- [Release notes](https://github.com/kubernetes-sigs/kubebuilder-release-tools/releases)
- [Changelog](https://github.com/kubernetes-sigs/kubebuilder-release-tools/blob/master/RELEASE.md)
- [Commits](https://github.com/kubernetes-sigs/kubebuilder-release-tools/compare/v0.4.0...v0.4.3)

---
updated-dependencies:
- dependency-name: kubernetes-sigs/kubebuilder-release-tools
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* OCPBUGS-28230: enforce termination message policy on all platform pods (#260)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

* bump controller-gen to v0.14.0 (#262)

Signed-off-by: Tayler Geiger <tayler@redhat.com>

* ⚠️ Serve catalog over HTTPS (#263)

* make catalog server serve catalog contents over HTTPS

adds cert-manager as a dependency again to create self-signed
certs for the catalog server

Signed-off-by: everettraven <everettraven@gmail.com>

* fix e2e

Signed-off-by: everettraven <everettraven@gmail.com>

* Reorganize manifests for cert-manager overlay

This allows the use of alternate certificate managers.

Signed-off-by: Tayler Geiger <tayler@redhat.com>

* Reconfigure TLS functionality to use Listener

Fix a few manifest issues as well.

Signed-off-by: Tayler Geiger <tayler@redhat.com>

* Add certwatcher for TLS cert and key from controller-runtime

- Add error for missing either tls-key or tls-cert arguments.
- Move server creation and configuration to serverutil

Signed-off-by: Tayler Geiger <tayler@redhat.com>

* Update README and docs for HTTPS

---------

Signed-off-by: everettraven <everettraven@gmail.com>
Signed-off-by: Tayler Geiger <tayler@redhat.com>
Co-authored-by: everettraven <everettraven@gmail.com>

* Makefile: fix issues with repeated evaluations (#267)

* rename Catalog to ClusterCatalog (#268)

Signed-off-by: everettraven <everettraven@gmail.com>

* ✨ Bump k8s deps to 0.30.0 and go 1.22 (#269)

* bump to go 1.22 and k8s 0.30.0

Signed-off-by: everettraven <everettraven@gmail.com>

* bump o-reg to tag

Signed-off-by: everettraven <everettraven@gmail.com>

---------

Signed-off-by: everettraven <everettraven@gmail.com>

* :seedling: Bump k8s.io/client-go from 0.30.0 to 0.30.1 (#276)

Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.30.0 to 0.30.1.
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](https://github.com/kubernetes/client-go/compare/v0.30.0...v0.30.1)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump k8s.io/component-base from 0.28.5 to 0.30.1 (#275)

Bumps [k8s.io/component-base](https://github.com/kubernetes/component-base) from 0.28.5 to 0.30.1.
- [Commits](https://github.com/kubernetes/component-base/compare/v0.28.5...v0.30.1)

---
updated-dependencies:
- dependency-name: k8s.io/component-base
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump k8s.io/apiserver from 0.28.5 to 0.30.1 (#274)

Bumps [k8s.io/apiserver](https://github.com/kubernetes/apiserver) from 0.28.5 to 0.30.1.
- [Commits](https://github.com/kubernetes/apiserver/compare/v0.28.5...v0.30.1)

---
updated-dependencies:
- dependency-name: k8s.io/apiserver
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix XDG_DATA_HOME build issue (#264)

This mirrors the same fix made previously in operator-controller: https://github.com/operator-framework/operator-controller/pull/790

Signed-off-by: Tayler Geiger <tayler@redhat.com>

* Change default namespace to olmv1-system (#283)

* :seedling: Bump k8s.io/apiextensions-apiserver from 0.30.0 to 0.30.2 (#284)

Bumps [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) from 0.30.0 to 0.30.2.
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.30.0...v0.30.2)

---
updated-dependencies:
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump github.com/containerd/containerd from 1.7.16 to 1.7.18 (#282)

Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.7.16 to 1.7.18.
- [Release notes](https://github.com/containerd/containerd/releases)
- [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md)
- [Commits](https://github.com/containerd/containerd/compare/v1.7.16...v1.7.18)

---
updated-dependencies:
- dependency-name: github.com/containerd/containerd
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix codecov-action params (#287)

* `functionalities` param is no longer exist.
  It was used to enable file fixes to ignore common lines from coverage.
  This feature is now seems to be on by default.

* Adding `disable_search` because we do not need for the codecov action
  to search for coverage files: we explicitly provide files.

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>

* Use url.Scheme to determine port number (#289)

Signed-off-by: Todd Short <todd.short@me.com>

* Fixing the labels for better identify metrics (#292)

As the label selector used for both catalogd and operator-controller
metrics services is "control-plane: controller-manager". Hence changing
the labels in both operator-controller and catalogd to make sure we
do not overlap.
Refer
https://github.com/operator-framework/operator-controller/issues/955 for
details

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

* adding gzip content support (#293)

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

* :seedling: Bump actions/add-to-project from 1.0.1 to 1.0.2 (#291)

Bumps [actions/add-to-project](https://github.com/actions/add-to-project) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/actions/add-to-project/releases)
- [Commits](https://github.com/actions/add-to-project/compare/v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: actions/add-to-project
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump github.com/prometheus/client_golang (#286)

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.18.0 to 1.19.1.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus/client_golang/compare/v1.18.0...v1.19.1)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump github.com/google/go-containerregistry (#285)

Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) from 0.19.1 to 0.19.2.
- [Release notes](https://github.com/google/go-containerregistry/releases)
- [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml)
- [Commits](https://github.com/google/go-containerregistry/compare/v0.19.1...v0.19.2)

---
updated-dependencies:
- dependency-name: github.com/google/go-containerregistry
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump github.com/go-logr/logr from 1.4.1 to 1.4.2 (#279)

Bumps [github.com/go-logr/logr](https://github.com/go-logr/logr) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/go-logr/logr/releases)
- [Changelog](https://github.com/go-logr/logr/blob/master/CHANGELOG.md)
- [Commits](https://github.com/go-logr/logr/compare/v1.4.1...v1.4.2)

---
updated-dependencies:
- dependency-name: github.com/go-logr/logr
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump github.com/onsi/ginkgo/v2 from 2.17.3 to 2.19.0 (#277)

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.17.3 to 2.19.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/ginkgo/compare/v2.17.3...v2.19.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump github.com/operator-framework/operator-registry (#281)

Bumps [github.com/operator-framework/operator-registry](https://github.com/operator-framework/operator-registry) from 1.42.0 to 1.43.1.
- [Release notes](https://github.com/operator-framework/operator-registry/releases)
- [Commits](https://github.com/operator-framework/operator-registry/compare/v1.42.0...v1.43.1)

---
updated-dependencies:
- dependency-name: github.com/operator-framework/operator-registry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* check the underlying storage for existing cluster catalog content (#290)

Signed-off-by: Igor Troyanovsky <itroyano@redhat.com>

* :seedling: Bump github.com/operator-framework/operator-registry (#294)

Bumps [github.com/operator-framework/operator-registry](https://github.com/operator-framework/operator-registry) from 1.43.1 to 1.44.0.
- [Release notes](https://github.com/operator-framework/operator-registry/releases)
- [Commits](https://github.com/operator-framework/operator-registry/compare/v1.43.1...v1.44.0)

---
updated-dependencies:
- dependency-name: github.com/operator-framework/operator-registry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Share common CA with OLMv1 in overlays/cert-manager (#296)

Use kustomization Components to share a common ClusterIssuer with
operator-controller.

Fixes #295

Signed-off-by: Todd Short <todd.short@me.com>

* :seedling: Bump github.com/containerd/containerd from 1.7.18 to 1.7.19 (#297)

Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.7.18 to 1.7.19.
- [Release notes](https://github.com/containerd/containerd/releases)
- [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md)
- [Commits](https://github.com/containerd/containerd/compare/v1.7.18...v1.7.19)

---
updated-dependencies:
- dependency-name: github.com/containerd/containerd
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* reduce cpu requests (#298)

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

* Remove second installation of cert-manager (#300)

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>

* Bump ginkgo CLI (#301)

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>

* :seedling: Bump github.com/google/go-containerregistry (#302)

Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) from 0.19.2 to 0.20.0.
- [Release notes](https://github.com/google/go-containerregistry/releases)
- [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml)
- [Commits](https://github.com/google/go-containerregistry/compare/v0.19.2...v0.20.0)

---
updated-dependencies:
- dependency-name: github.com/google/go-containerregistry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump google.golang.org/grpc from 1.64.0 to 1.64.1 (#303)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.64.0 to 1.64.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.64.0...v1.64.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* shift gzip lib to active fork (#311)

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

* Move all packages from /pkg to /internal (#310)

Ahead of an initial 1.0.0 release, we shouldn't preemptively
expose any packages publicly. Instead, let's start my making
any packages internal, and we can expose them publicly
later on. This commit moves everything currently in /pkg
to /internal for now.

Signed-off-by: kevinrizza <krizza@redhat.com>

* :seedling: Bump github.com/klauspost/compress from 1.17.8 to 1.17.9 (#312)

Bumps [github.com/klauspost/compress](https://github.com/klauspost/compress) from 1.17.8 to 1.17.9.
- [Release notes](https://github.com/klauspost/compress/releases)
- [Changelog](https://github.com/klauspost/compress/blob/master/.goreleaser.yml)
- [Commits](https://github.com/klauspost/compress/compare/v1.17.8...v1.17.9)

---
updated-dependencies:
- dependency-name: github.com/klauspost/compress
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump github.com/google/go-containerregistry (#315)

Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) from 0.20.0 to 0.20.1.
- [Release notes](https://github.com/google/go-containerregistry/releases)
- [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml)
- [Commits](https://github.com/google/go-containerregistry/compare/v0.20.0...v0.20.1)

---
updated-dependencies:
- dependency-name: github.com/google/go-containerregistry
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump github.com/operator-framework/operator-registry (#319)

Bumps [github.com/operator-framework/operator-registry](https://github.com/operator-framework/operator-registry) from 1.44.0 to 1.45.0.
- [Release notes](https://github.com/operator-framework/operator-registry/releases)
- [Commits](https://github.com/operator-framework/operator-registry/compare/v1.44.0...v1.45.0)

---
updated-dependencies:
- dependency-name: github.com/operator-framework/operator-registry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump k8s.io/apiextensions-apiserver from 0.30.2 to 0.30.3 (#320)

Bumps [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) from 0.30.2 to 0.30.3.
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.30.2...v0.30.3)

---
updated-dependencies:
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Include OperatorHub.io ClusterCatalog in releases (#321)

Also adds optional instructions for adding the OperatorHub.io
ClusterCatalog to a cluster.

Signed-off-by: Tayler Geiger <tayler@redhat.com>

* ✨ json-lines interface: set content-type, enforce format, document interface (#313)

* set content-type for ndjson

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

* generate json-lines validation data

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

* added docs for interface format

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

---------

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

* :seedling: Bump github.com/containerd/containerd from 1.7.19 to 1.7.20 (#324)

Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.7.19 to 1.7.20.
- [Release notes](https://github.com/containerd/containerd/releases)
- [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md)
- [Commits](https://github.com/containerd/containerd/compare/v1.7.19...v1.7.20)

---
updated-dependencies:
- dependency-name: github.com/containerd/containerd
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add dependabot K8s dependencies group (#322)

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>

* add catalogd upgrade test (#314)

Signed-off-by: Ankita Thomas <ankithom@redhat.com>

* Add installation script (#325)

This follows the release pattern used in operator-controller where an
install.sh script is used for a multi-step installation process. The
OperatorHub ClusterCatalog is also included in the release artifacts.
Also adjusted the Makefile to use the install.sh for deploy.

Signed-off-by: Tayler Geiger <tayler@redhat.com>

* Update run-latest-release Makefile target (#326)

* 🌱 Revert 2 previous PRs (#327)

* Revert "Update run-latest-release Makefile target (#326)"

This reverts commit 74de15aa8e50e0764eb7f97c1a667dc41b471a9a.

* Revert "Add installation script (#325)"

This reverts commit bad488ef1e8245db4e2ca7bb90b6ef7a7a3e4f63.

* Add installation script to releases (#328)

This follows the release pattern used in operator-controller where an
install.sh script is used for a multi-step installation process. The
OperatorHub ClusterCatalog is also included in the release artifacts.
Also adjusted the Makefile to use the install.sh for deploy.

Signed-off-by: Tayler Geiger <tayler@redhat.com>

* Edit Makefile targets to use install.sh (#329)

Adjusts several Makefile targets to use the new install.sh script.
Includes adjustments to test-upgrade-e2e to use a new target that only
installs the catalogd manifest so cert-manager can still be installed
first for use in the image registry.

Signed-off-by: Tayler Geiger <tayler@redhat.com>

* capturing gzip catalog demo as asciicast (#323)

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

* :seedling: Bump github.com/onsi/gomega from 1.33.1 to 1.34.0 (#332)

Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.33.1 to 1.34.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/gomega/compare/v1.33.1...v1.34.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump github.com/onsi/ginkgo/v2 from 2.19.0 to 2.19.1 (#331)

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.19.0 to 2.19.1.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/ginkgo/compare/v2.19.0...v2.19.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump github.com/onsi/gomega from 1.34.0 to 1.34.1 (#333)

Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.34.0 to 1.34.1.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/gomega/compare/v1.34.0...v1.34.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* default-catalogs.yaml: add 10m poll (#335)

* ✨ initial api audit type alignment (#330)

* initial api audit

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

* review resolutions

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

---------

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

* :seedling: Bump github.com/onsi/ginkgo/v2 from 2.19.1 to 2.20.0 (#338)

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.19.1 to 2.20.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/ginkgo/compare/v2.19.1...v2.20.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump github.com/google/go-containerregistry (#337)

Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) from 0.20.1 to 0.20.2.
- [Release notes](https://github.com/google/go-containerregistry/releases)
- [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml)
- [Commits](https://github.com/google/go-containerregistry/compare/v0.20.1...v0.20.2)

---
updated-dependencies:
- dependency-name: github.com/google/go-containerregistry
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump github.com/prometheus/client_golang (#344)

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.19.1 to 1.20.0.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/v1.20.0/CHANGELOG.md)
- [Commits](https://github.com/prometheus/client_golang/compare/v1.19.1...v1.20.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump the k8s-dependencies group with 6 updates (#343)

* :seedling: Bump the k8s-dependencies group with 6 updates

Bumps the k8s-dependencies group with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api) | `0.30.3` | `0.31.0` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.30.3` | `0.31.0` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.30.3` | `0.31.0` |
| [k8s.io/apiserver](https://github.com/kubernetes/apiserver) | `0.30.3` | `0.31.0` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.30.3` | `0.31.0` |
| [k8s.io/component-base](https://github.com/kubernetes/component-base) | `0.30.3` | `0.31.0` |


Updates `k8s.io/api` from 0.30.3 to 0.31.0
- [Commits](https://github.com/kubernetes/api/compare/v0.30.3...v0.31.0)

Updates `k8s.io/apiextensions-apiserver` from 0.30.3 to 0.31.0
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.30.3...v0.31.0)

Updates `k8s.io/apimachinery` from 0.30.3 to 0.31.0
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.30.3...v0.31.0)

Updates `k8s.io/apiserver` from 0.30.3 to 0.31.0
- [Commits](https://github.com/kubernetes/apiserver/compare/v0.30.3...v0.31.0)

Updates `k8s.io/client-go` from 0.30.3 to 0.31.0
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](https://github.com/kubernetes/client-go/compare/v0.30.3...v0.31.0)

Updates `k8s.io/component-base` from 0.30.3 to 0.31.0
- [Commits](https://github.com/kubernetes/component-base/compare/v0.30.3...v0.31.0)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apiserver
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/component-base
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump controller-runtime from 0.18.4 to 0.19.0

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Per Goncalves da Silva <pegoncal@redhat.com>

* :seedling: change GVK to use olm.operatorframework.io (#342)

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

* Removing the catalogd from  app.kubernetes.io/name (#347)

As this namespace is shared between catalogd operator-framework-catalogd

Fixes issue #346

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

* :seedling: Bump github.com/operator-framework/operator-registry from 1.45.0 to 1.46.0 (#345)

* :seedling: Bump github.com/operator-framework/operator-registry

Bumps [github.com/operator-framework/operator-registry](https://github.com/operator-framework/operator-registry) from 1.45.0 to 1.46.0.
- [Release notes](https://github.com/operator-framework/operator-registry/releases)
- [Commits](https://github.com/operator-framework/operator-registry/compare/v1.45.0...v1.46.0)

---
updated-dependencies:
- dependency-name: github.com/operator-framework/operator-registry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* bump controller-gen to v0.16.1

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Per Goncalves da Silva <pegoncal@redhat.com>

* ✨ Capture catalog content timestamp in ClusterCatalogStatus (#334)

* Capture catalog content timestamp in ClusterCatalogStatus

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>

* address reviews (partial)

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>

* address review feedback

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>

* Address review comments

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>

---------

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>

* :seedling: Bump github.com/onsi/ginkgo/v2 from 2.20.0 to 2.20.1 (#350)

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.20.0 to 2.20.1.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/ginkgo/compare/v2.20.0...v2.20.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump github.com/prometheus/client_golang (#351)

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.0 to 1.20.2.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus/client_golang/compare/v1.20.0...v1.20.2)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump github.com/containerd/containerd from 1.7.20 to 1.7.21 (#352)

Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.7.20 to 1.7.21.
- [Release notes](https://github.com/containerd/containerd/releases)
- [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md)
- [Commits](https://github.com/containerd/containerd/compare/v1.7.20...v1.7.21)

---
updated-dependencies:
- dependency-name: github.com/containerd/containerd
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Catalog Priority (#353)

Adds an int32 field to allow users to optionally set priority of catalogs. This priority value may be taken into account during bundle selection from multiple catalogs to remove ambiguity.

Signed-off-by: dtfranz <dfranz@redhat.com>

* add v1.0 and v1.x issues to OLMv1 project automatically (#354)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

* :seedling: Bump bingo + tools (#358)

* Add bingo-upgrade target to Makefile

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

* Upgrade bingo tools

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

* Regenerate manifests

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

---------

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Co-authored-by: Per Goncalves da Silva <pegoncal@redhat.com>

* bugfix: fix printcolumn for lastUnpacked based on json tag and not field name (#361)

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>

* :seedling: Bump github.com/onsi/ginkgo/v2 from 2.20.1 to 2.20.2 (#360)

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.20.1 to 2.20.2.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/ginkgo/compare/v2.20.1...v2.20.2)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* :seedling: Bump github.com/onsi/gomega from 1.34.1 to 1.34.2 (#359)

Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.34.1 to 1.34.2.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/gomega/compare/v1.34.1...v1.34.2)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update cert-manager to v1.15.3 (#367)

Signed-off-by: Todd Short <todd.short@me.com>

* Remove status.phase field from the code and doc references (#368)

Signed-off-by: Todd Short <todd.short@me.com>

* 🌱 Add webhook to add a name label to ClusterCatalogs (#356)

* Add webhook to name label ClusterCatalogs

* Linter fixups

* Added bit more webhook test coverage

* Use catalogd version & clean up TLS args

Signed-off-by: Brett Tofel <btofel@redhat.com>

* Fix label name

Signed-off-by: Brett Tofel <btofel@redhat.com>

* From stand-alone webhook to operator internal

Signed-off-by: Brett Tofel <btofel@redhat.com>

* Think this fixes e2e-upgrade

not sure why PR changes might necessitate this, but it seems legit to delete deployment first

Signed-off-by: Brett Tofel <btofel@redhat.com>

* PR review changes so far...

- get MutaingWebhookConfig from kubebuilder;
- stop deleting deployment on only-deploy;
- use the existing matchLabel, stop adding webhook label to operator;
- rename the name label to metadata.name (but not in API yet).

Signed-off-by: Brett Tofel <btofel@redhat.com>

* Restore CA issuer config

Signed-off-by: Brett Tofel <btofel@redhat.com>

* Fix unit tests

Signed-off-by: Brett Tofel <btofel@redhat.com>

* Addresses review comments around TLS cert config

Signed-off-by: Brett Tofel <btofel@redhat.com>

* Move RBAC for webhook to kb directive

Signed-off-by: Brett Tofel <btofel@redhat.com>

* Move allow-direct-injection to secretTemplate

Signed-off-by: Brett Tofel <btofel@redhat.com>

* Make metadata.name an API constant

Signed-off-by: Brett Tofel <btofel@redhat.com>

* Use MetaDataNameLabel API constant in log line

Signed-off-by: Brett Tofel <btofel@redhat.com>

* Combine cert watchers

Signed-off-by: Brett Tofel <btofel@redhat.com>

* Move cert watching back to ctr-rt manager

Signed-off-by: Brett Tofel <btofel@redhat.com>

* Address review comments

Signed-off-by: Brett Tofel <btofel@redhat.com>

* Address review comments 2

Signed-off-by: Brett Tofel <btofel@redhat.com>

---------

Signed-off-by: Brett Tofel <btofel@redhat.com>

* Move cert-manager.io patch into tls component (#372)

Signed-off-by: Todd Short <todd.short@me.com>

* :seedling: Bump github.com/prometheus/client_golang (#375)

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.2 to 1.20.3.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/v1.20.3/CHANGELOG.md)
- [Commits](https://github.com/prometheus/client_golang/compare/v1.20.2...v1.20.3)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add label creation checking in the e2e (#374)

Signed-off-by: Todd Short <todd.short@me.com>

* Add matchCondition to webhook config (#376)

Should add some efficiency as it only lets the webhook fire when needed

Signed-off-by: Brett Tofel <btofel@redhat.com>

* Fix matchConditions to be compatible with GenerateName (#382)

Signed-off-by: Todd Short <todd.short@me.com>

* Force a rename of the catalogd certificate (#386)

This will cause the catalogd deployment to restart, meaning that the
catalogd will update quicker (rather than waiting on k8s to update the
certificates via the volume)

Signed-off-by: Todd Short <todd.short@me.com>

* :seedling: Bump github.com/operator-framework/operator-registry (#387)

Bumps [github.com/operator-framework/operator-registry](https://github.com/operator-framework/operator-registry) from 1.46.0 to 1.47.0.
- [Release notes](https://github.com/operator-framework/operator-registry/releases)
- [Commits](https://github.com/operator-framework/operator-registry/compare/v1.46.0...v1.47.0)

---
updated-dependencies:
- dependency-name: github.com/operator-framework/operator-registry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 📖 [Docs] Document tilt-support install (#388)

* Document tilt-support install

Signed-off-by: Brett Tofel <btofel@redhat.com>

* Improve tilt-support text

Signed-off-by: Brett Tofel <btofel@redhat.com>

---------

Signed-off-by: Brett Tofel <btofel@redhat.com>

* :seedling: Bump github.com/containerd/containerd from 1.7.21 to 1.7.22 (#391)

Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.7.21 to 1.7.22.
- [Release notes](https://github.com/containerd/containerd/releases)
- [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md)
- [Commits](https://github.com/containerd/containerd/compare/v1.7.21...v1.7.22)

---
updated-dependencies:
- dependency-name: github.com/containerd/containerd
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ✨ Ensure docker registry CA is trusted in e2e tests (#377)

* Ensure docker registry CA is trusted in e2e tests

* Restructure based on feedback

* Fix FS cache for image refs with tags (#394)

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>

* Fixes name of httputil test file (#395)

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Co-authored-by: Per Goncalves da Silva <pegoncal@redhat.com>

* Add .idea to .gitignore (#393)

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Co-authored-by: Per Goncalves da Silva <pegoncal@redhat.com>

* Remove TLSVerify/PullSecret fields (#369)

Remove fields that will not have long term support committed to them to
prepare for the v1.0 release.

Removed Fields:
- spec.source.image.insecureSkipTLSVerify
- spec.source.image.pullSecret

GH Issue Ref: #355

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

* Avoid a network call for digest based images (#396)

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>

* :seedling: Bump the k8s-dependencies group with 6 updates (#398)

Bumps the k8s-dependencies group with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api) | `0.31.0` | `0.31.1` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.31.0` | `0.31.1` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.31.0` | `0.31.1` |
| [k8s.io/apiserver](https://github.com/kubernetes/apiserver) | `0.31.0` | `0.31.1` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.31.0` | `0.31.1` |
| [k8s.io/component-base](https://github.com/kubernetes/component-base) | `0.31.0` | `0.31.1` |


Updates `k8s.io/api` from 0.31.0 to 0.31.1
- [Commits](https://github.com/kubernetes/api/compare/v0.31.0...v0.31.1)

Updates `k8s.io/apiextensions-apiserver` from 0.31.0 to 0.31.1
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.31.0...v0.31.1)

Updates `k8s.io/apimachinery` from 0.31.0 to 0.31.1
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.31.0...v0.31.1)

Updates `k8s.io/apiserver` from 0.31.0 to 0.31.1
- [Commits](https://github.com/kubernetes/apiserver/compare/v0.31.0...v0.31.1)

Updates `k8s.io/client-go` from 0.31.0 to 0.31.1
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](https://github.com/kubernetes/client-go/compare/v0.31.0...v0.31.1)

Updates `k8s.io/component-base` from 0.31.0 to 0.31.1
- [Commits](https://github.com/kubernetes/component-base/compare/v0.31.0...v0.31.1)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/component-base
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix unnecessary lastUnpacked status updates (#397)

We should not be updating lastUnpacked status fields when
we read from the cache

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>

* ✨ unpacker: switch from google/go-containerregistry to containers/image (#399)

* copy containers_image.go from operator-controller

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

* initial modifications for naming and types

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

* unpacker: switch to containers/image-based implementation

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

---------

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

* :seedling: Align ClusterCatalog API godoc with OpenShift API conventions (#390)

* Update godoc strings for ClusterCatalog API

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

* Regenerate manifests

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

* Apply suggestions from code review

Text fixes

Co-authored-by: Bryce Palmer <everettraven@gmail.com>

* Address reviewer comments

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

* Update api/core/v1alpha1/clustercatalog_types.go

Co-authored-by: Bryce Palmer <everettraven@gmail.com>

* Apply suggestions from code review

Co-authored-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

---------

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Co-authored-by: Per Goncalves da Silva <pegoncal@redhat.com>
Co-authored-by: Bryce Palmer <everettraven@gmail.com>
Co-authored-by: Joe Lanford <joe.lanford@gmail.com>

* Add CI to check if golang version updated (#401)

Signed-off-by: Todd Short <todd.short@me.com>

* Combine the catalogd services (#402)

Only need to define one service for:
* metrics
* webhook
* catalogd itself

Clean up the name of the service (now `catalogd-service`) and any
corresponding resources

Renumber the ports to 7443/8443/9443. The external port for the catalog
server is either 80 or 443.

Signed-off-by: Todd Short <todd.short@me.com>

* Update documentation and default to new service name. (#406)

Signed-off-by: Todd Short <todd.short@me.com>

* fix: make post-upgrade-e2e checks wait for ClusterCatalog to be reconciled (#407)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

* fix: unpack cache cleanup should ignore missing files (#404)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

* use controller-runtime Terminal error instead of custom Unrecoverable error (#405)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

* Refer to the correct location for go-verdiff (#408)

The location is different than the operator-controller repo.

Signed-off-by: Todd Short <todd.short@me.com>

* :seedling: Bump github.com/prometheus/client_golang (#403)

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.3 to 1.20.4.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus/client_golang/compare/v1.20.3...v1.20.4)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 🐛 Handle finalizers (creation and deletion) better (#411)

* 🐛 Handle finalizers (creation and deletion) better

Closes [409](https://github.com/operator-framework/catalogd/issues/409)

* Move the finalizer setup

Move the finalizer setup out from main.go, and into the controller
code. This allows the finalizers to be initialized and used in the
test code.

Signed-off-by: Todd Short <todd.short@me.com>

* Undo rename of fbcDeletionFinalizer

Signed-off-by: Todd Short <todd.short@me.com>

---------

Signed-off-by: Todd Short <todd.short@me.com>
Co-authored-by: Todd Short <todd.short@me.com>

* ⚠ Status condition clean up (#379)

* ⚠ Status condition clean up

[RFC: Cl…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everettraven everettraven everettraven approved these changes

@joelanford joelanford joelanford approved these changes

@dtfranz dtfranz Awaiting requested review from dtfranz

@tmshort tmshort Awaiting requested review from tmshort

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

e2e flake: [FAILED] Operator Install when An operator is installed from an operator catalog
4 participants
@anik120 @joelanford @everettraven @openshift-merge-robot