Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes unnecessary HaveLen assertions #272

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Removes unnecessary HaveLen assertions #272

merged 1 commit into from
Jun 27, 2023

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Jun 22, 2023

Description

Follow up for #264:

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2023
@m1kola
Removes unnecessary HaveLen assertions
b526a4e 
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola m1kola marked this pull request as ready for review June 22, 2023 10:12
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2023
@m1kola m1kola requested a review from ankitathomas June 22, 2023 10:12
ankitathomas
ankitathomas approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@ankitathomas ankitathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2023
@m1kola m1kola merged commit 0b82490 into operator-framework:main Jun 27, 2023
@m1kola m1kola deleted the test_cleanup branch June 27, 2023 08:53
@m1kola m1kola mentioned this pull request Jun 27, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitathomas ankitathomas ankitathomas approved these changes

@everettraven everettraven everettraven approved these changes

Assignees

@ankitathomas ankitathomas

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m1kola @ankitathomas @everettraven