Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes resolver_test.go #282

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Jun 29, 2023

Description

Follow up for #248 (comment)

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #282 (91d4267) into main (ebc5cfe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #282   +/-   ##
=======================================
  Coverage   76.13%   76.13%           
=======================================
  Files          13       13           
  Lines         662      662           
=======================================
  Hits          504      504           
  Misses        129      129           
  Partials       29       29           

@m1kola m1kola marked this pull request as ready for review June 29, 2023 12:45
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2023
@m1kola m1kola requested a review from jubittajohn June 29, 2023 12:46
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2023
@m1kola m1kola merged commit b7a737a into operator-framework:main Jun 29, 2023
9 checks passed
@m1kola m1kola deleted the remove_resolver_test branch June 29, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants