Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up kustomize files & gets rid of deprecated fields #283

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Jul 3, 2023

Description

  • patchesStrategicMerge is deprecated
  • config/default/manager_config_patch.yaml is unused
  • Removes some unused scaffolding

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #283 (47c4f0a) into main (70407ba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #283   +/-   ##
=======================================
  Coverage   77.00%   77.00%           
=======================================
  Files          15       15           
  Lines         687      687           
=======================================
  Hits          529      529           
  Misses        129      129           
  Partials       29       29           

@m1kola m1kola marked this pull request as ready for review July 3, 2023 11:09
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2023
* `patchesStrategicMerge` is deprecated
* `config/default/manager_config_patch.yaml` is unused
* Removes some unused scaffolding

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola m1kola merged commit 0eeeb0a into operator-framework:main Jul 5, 2023
9 checks passed
@m1kola m1kola deleted the kustomize-cleanup branch July 5, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants