Adds E2E coverage reporting

[m1kola]

Description

Adds E2E coverage reporting.

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[perdasilva]

great use of comments ^^ thank you!

[perdasilva]

I think this looks really good. Very tidy. You're experience as an SRE really comes through. What do you think is missing before we can take it off draft state?

[m1kola]

@perdasilva thanks for the review.

What do you think is missing before we can take it off draft state?

There were few things which I wanted to change before marking ready for review:

• I didn't want to have a bunch of kubectl commands in the Makefile They are now in ./hack/e2e-coverage.sh.
• I didn't like the very long json in --overrides in kubectl run. I moved pod creation into config/e2e/manager_e2e_coverage_copy_pod.yaml.
• I had to change github action to make sure that we collect coverage even if tests fail. In the previous version coverage was only collected on success due to make aborting execution on first non-zero exit code. I added -k/--keep-going flag to make -k e2e which will continue make build, but will return non-zero exit code in case of failures.

The PR should be ready now. I'm just checking few things before I actually take it off the draft state.

[codecov]

Codecov Report

Merging #284 (6bcb822) into main (3c55b14) will increase coverage by 3.69%.
The diff coverage is n/a.

❗ Current head 6bcb822 differs from pull request most recent head 69e9c72. Consider uploading reports for the commit 69e9c72 to get more accurate results

@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   77.00%   80.69%   +3.69%     
==========================================
  Files          15       18       +3     
  Lines         687      803     +116     
==========================================
+ Hits          529      648     +119     
+ Misses        129      112      -17     
- Partials       29       43      +14     

Flag	Coverage Δ
e2e	55.79% <ø> (?)
unit	77.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes