Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use env vars for possible e2e test image substitution #289

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

grokspawn
Copy link
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #289 (a1fc2fe) into main (61b563f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #289   +/-   ##
=======================================
  Coverage   77.00%   77.00%           
=======================================
  Files          15       15           
  Lines         687      687           
=======================================
  Hits          529      529           
  Misses        129      129           
  Partials       29       29           

@ncdc ncdc merged commit 83d0403 into operator-framework:main Jul 6, 2023
9 checks passed
@grokspawn grokspawn deleted the image-ref-template branch July 6, 2023 18:27
awgreene pushed a commit to awgreene/operator-controller that referenced this pull request Oct 13, 2023
…work#289)

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
(cherry picked from commit 83d0403)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants