Add initial Tilt support #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #297 +/- ##
=======================================
Coverage 80.69% 80.69%
=======================================
Files 18 18
Lines 803 803
=======================================
Hits 648 648
Misses 112 112
Partials 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. |
tmshort
reviewed
Jul 25, 2023
| This is typically a short as: | ||
|
|
||
| ```shell | ||
| tilt up |
There was a problem hiding this comment.
- Does this need to be run inside the git repo?
- Does this "take over" the shell/terminal? (i.e. recommend opening another terminal?)
| Here is the same workflow with Tilt: | ||
|
|
||
| 1. Run `tilt up` | ||
| 2. Modify the source code |
There was a problem hiding this comment.
Might want to emphasize "with your preferred editor", so people don't think you need to use the Tilt interface.
There was a problem hiding this comment.
I don't think it's likely people will be confused.
|
Updated, thanks |
tmshort
reviewed
Jul 25, 2023
tmshort
requested changes
Jul 25, 2023
|
No because the context when building images in bin/linux |
I see that now, it was a bit hard because of some inconsistencies in the Makefile (i.e. the use of |
tmshort
approved these changes
Jul 25, 2023
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
|
/lgtm |
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add initial Tilt support
Reviewer Checklist