Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes codecov-action optional #304

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Jul 28, 2023

Description

We do not want to fail the job if codecov fails
to upload the report due to rate limiting.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

We do not want to fail the job if codecov fails
to upload the report due to rate limiting.

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola m1kola requested a review from a team as a code owner July 28, 2023 15:09
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #304 (0959b47) into main (18a6be4) will increase coverage by 3.69%.
Report is 5 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   77.00%   80.69%   +3.69%     
==========================================
  Files          15       18       +3     
  Lines         687      803     +116     
==========================================
+ Hits          529      648     +119     
+ Misses        129      112      -17     
- Partials       29       43      +14     
Flag Coverage Δ
e2e 55.79% <ø> (?)
unit 77.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@ncdc ncdc merged commit 14c9a3d into operator-framework:main Jul 28, 2023
9 checks passed
@m1kola m1kola deleted the codecov_do-not-fail-please branch July 28, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants