Switch to using tilt-support repo #307
Conversation
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
Codecov Report
@@ Coverage Diff @@
## main #307 +/- ##
=======================================
Coverage 80.69% 80.69%
=======================================
Files 18 18
Lines 803 803
=======================================
Hits 648 648
Misses 112 112
Partials 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. |
| # This loads a helper function that isn't part of core Tilt that simplifies restarting the process in the container | ||
| # when files changes. | ||
| load('ext://restart_process', 'docker_build_with_restart') | ||
| if not os.path.exists('../tilt-support'): |
There was a problem hiding this comment.
I'm very leery about going outside the repo.
There was a problem hiding this comment.
This is for local development and iteration. It's pretty standard.
There was a problem hiding this comment.
This doesn't clone the tilt-support repo. That's something you have to do manually. It's definitely not forcing arbitrary code from the internet on you 😄
An alternative is to consider tilt-support a Tilt extension:
v1alpha1.extension_repo(name='tilt-support', url='https://github.com/operator-framework/tilt-support')
v1alpha1.extension(name='tilt-support', repo_name='tilt-support', repo_path='.')
load('ext://tilt-support', 'deploy_repo')
Both would load the same code
There was a problem hiding this comment.
I just said I'm "leery". I haven't seen many (if any?) projects that look outside their repository unless explicitly configured to do so by the user (e.g. --with-software=/path/to/software). Then again, I'm also leery about pulling random software versions from the 'net (given my corporate security background).
That said, if it's just looking for something, then it's not so bad.
There was a problem hiding this comment.
Ok, cool. Yeah this is by far the easiest way.
Description
Requires operator-framework/tilt-support#1
Reviewer Checklist