Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for tilt #319

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Add CI for tilt #319

merged 1 commit into from
Aug 4, 2023

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Aug 3, 2023

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@ncdc ncdc requested a review from a team as a code owner August 3, 2023 17:32
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #319 (21ca19c) into main (c145c46) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #319   +/-   ##
=======================================
  Coverage   82.35%   82.35%           
=======================================
  Files          21       21           
  Lines         890      890           
=======================================
  Hits          733      733           
  Misses        109      109           
  Partials       48       48           
Flag Coverage Δ
e2e 62.58% <ø> (ø)
unit 78.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if paths-ignore will be easier to maintain than paths. Other than that - looks good to me.

@@ -0,0 +1,48 @@
on:
pull_request:
paths:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe paths-ignore is more suitable here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept going back and forth on this. I can switch it if you'd prefer.

@ncdc
Copy link
Member Author

ncdc commented Aug 4, 2023

Proceeding to merge given the approval. Can adjust the paths config if needed in a follow up.

@ncdc ncdc merged commit fa84c73 into operator-framework:main Aug 4, 2023
10 checks passed
@ncdc ncdc deleted the tilt-ci branch August 4, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants