-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI for tilt #319
Add CI for tilt #319
Conversation
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
Codecov Report
@@ Coverage Diff @@
## main #319 +/- ##
=======================================
Coverage 82.35% 82.35%
=======================================
Files 21 21
Lines 890 890
=======================================
Hits 733 733
Misses 109 109
Partials 48 48
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if paths-ignore
will be easier to maintain than paths
. Other than that - looks good to me.
@@ -0,0 +1,48 @@ | |||
on: | |||
pull_request: | |||
paths: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe paths-ignore
is more suitable here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept going back and forth on this. I can switch it if you'd prefer.
Proceeding to merge given the approval. Can adjust the paths config if needed in a follow up. |
Description
Reviewer Checklist