Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(doc-site) Remove PRD from doc site #324

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented Aug 7, 2023

Also order docs in the Tasks folder using 'nav' in mkdocs.yml

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@anik120 anik120 requested a review from a team as a code owner August 7, 2023 18:24
@oceanc80
Copy link
Contributor

oceanc80 commented Aug 7, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #324 (3804de7) into main (949c06a) will increase coverage by 1.66%.
Report is 8 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
+ Coverage   80.69%   82.35%   +1.66%     
==========================================
  Files          18       21       +3     
  Lines         803      890      +87     
==========================================
+ Hits          648      733      +85     
+ Misses        112      109       -3     
- Partials       43       48       +5     
Flag Coverage Δ
e2e 62.58% <ø> (+6.79%) ⬆️
unit 78.10% <ø> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

@oceanc80
Copy link
Contributor

oceanc80 commented Aug 7, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2023
Also order docs in the Tasks folder using 'nav' in mkdocs.yml

Signed-off-by: Anik <anikbhattacharya93@gmail.com>
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2023
@ncdc
Copy link
Member

ncdc commented Aug 22, 2023

Going to merge and do some follow ups

@ncdc ncdc added this pull request to the merge queue Aug 22, 2023
Merged via the queue into operator-framework:main with commit da63519 Aug 22, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants