Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoC: refactoring variable sources, experimenting with more constraints #331

Closed
wants to merge 1 commit into from
Closed

PoC: refactoring variable sources, experimenting with more constraints #331

wants to merge 1 commit into from

Conversation

joelanford
Copy link
Member

@joelanford joelanford commented Aug 11, 2023 •
edited
Loading

Description

I took some time to learn a bit more about how operator-controller works with deppy, and this is the result. So far I've got:

  • stop using entity sources
  • using catalogd's CatalogMetadata API
  • add support for hard-coded semver-based upgrade edges
  • add support for cluster range and node count constraints from bundles
  • add support for version ranges being specified in spec.version
  • add knob to Operator API to disable upgrade edge constraint
  • add knob to Operator API to disable cluster constraints

Using this PR requires installing catalogd with feature gate CatalogMetadataAPI=true (see operator-framework/catalogd#138)

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 11, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2023
@joelanford
wip
31082f4 
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2023
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joelanford joelanford closed this Sep 5, 2023
@m1kola m1kola mentioned this pull request Oct 4, 2023
Closed
4 tasks
@m1kola m1kola mentioned this pull request Nov 8, 2023
Merged
4 tasks
@joelanford joelanford deleted the var-sources branch June 20, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joelanford @openshift-merge-robot