Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete cluster before creating op-dev-e2e test #353

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Aug 22, 2023

Fixes #350

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Fixes operator-framework#350

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort requested a review from a team as a code owner August 22, 2023 15:20
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #353 (2431913) into main (fd7cfb5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #353   +/-   ##
=======================================
  Coverage   82.84%   82.84%           
=======================================
  Files          21       21           
  Lines         892      892           
=======================================
  Hits          739      739           
  Misses        107      107           
  Partials       46       46           
Flag Coverage Δ
e2e 62.66% <ø> (ø)
unit 78.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@joelanford joelanford added this pull request to the merge queue Aug 22, 2023
Merged via the queue into operator-framework:main with commit 2b17963 Aug 22, 2023
10 checks passed
@m1kola
Copy link
Member

m1kola commented Aug 23, 2023

I think it doesn't fix #350 since the issue is in deploy-local-registry target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make operator-developer-e2e fails when container with name "local-registry" is already exists
3 participants