Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: fix gomega assertion that breaks Eventually semantics #412

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

joelanford
Copy link
Member

Description

See: https://github.com/operator-framework/operator-controller/actions/runs/6187398899/job/16797170708?pr=410

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford requested a review from a team as a code owner September 14, 2023 18:23
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (21dbd8d) 83.97% compared to head (0bd592a) 83.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #412   +/-   ##
=======================================
  Coverage   83.97%   83.97%           
=======================================
  Files          27       27           
  Lines        1073     1073           
=======================================
  Hits          901      901           
  Misses        119      119           
  Partials       53       53           
Flag Coverage Δ
e2e 61.82% <ø> (ø)
unit 80.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ncdc ncdc enabled auto-merge September 14, 2023 18:27
@ncdc ncdc added this pull request to the merge queue Sep 14, 2023
Merged via the queue into operator-framework:main with commit 3646392 Sep 14, 2023
11 checks passed
@joelanford joelanford deleted the e2e-gomega-fix branch June 20, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants