Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Entities and EntitySources #413

Merged

Fix tests, bump catalogd, address comments.

d35618b
Select commit
Loading
Failed to load commit list.
Merged

Remove Entities and EntitySources #413

Fix tests, bump catalogd, address comments.
d35618b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 21, 2023 in 0s

84.42% (+0.45%) compared to 6640aac

View this Pull Request on Codecov

84.42% (+0.45%) compared to 6640aac

Details

Codecov Report

Patch coverage: 91.22% and project coverage change: +0.45% 🎉

Comparison is base (6640aac) 83.97% compared to head (d35618b) 84.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
+ Coverage   83.97%   84.42%   +0.45%     
==========================================
  Files          27       23       -4     
  Lines        1073      777     -296     
==========================================
- Hits          901      656     -245     
+ Misses        119       86      -33     
+ Partials       53       35      -18     
Files Changed Coverage Δ
...al/resolution/variablesources/installed_package.go 65.21% <53.84%> (-6.22%) ⬇️
...nal/resolution/variablesources/required_package.go 74.41% <90.00%> (+0.60%) ⬆️
internal/controllers/operator_controller.go 80.81% <90.90%> (+0.10%) ⬆️
...lution/variablesources/bundles_and_dependencies.go 96.00% <93.33%> (+4.16%) ⬆️
cmd/manager/main.go 70.58% <100.00%> (+0.58%) ⬆️
internal/catalogmetadata/client/client.go 89.47% <100.00%> (ø)
internal/controllers/variable_source.go 100.00% <100.00%> (ø)
internal/resolution/variables/bundle.go 100.00% <100.00%> (ø)
internal/resolution/variables/installed_package.go 100.00% <100.00%> (ø)
internal/resolution/variables/required_package.go 100.00% <100.00%> (ø)
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.