Renames NewClient to New to avoid duplication when imported
#422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
m1kola
changed the title
NewClient to New to avoid stutteringNewClient to New to avoid duplication when imported
So we can call `client.New` instead of `client.NewClient` Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
==========================================
- Coverage 83.97% 83.78% -0.19%
==========================================
Files 27 27
Lines 1073 1073
==========================================
- Hits 901 899 -2
- Misses 119 120 +1
- Partials 53 54 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
jmprusi
approved these changes
Sep 20, 2023
Merged
via the queue into
operator-framework:main
with commit Sep 20, 2023
cdb99fa
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So we can call
client.Newinstead ofclient.NewClient.Follow up for https://github.com/operator-framework/operator-controller/pull/413/files#r1330665212
Reviewer Checklist