Fixes semver range parsing for required packages

[m1kola]

Description

Moving fix from #413 into a separate PR.

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.19% ⚠️

Comparison is base (cdb99fa) 83.97% compared to head (a603662) 83.78%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
- Coverage   83.97%   83.78%   -0.19%     
==========================================
  Files          27       27              
  Lines        1073     1073              
==========================================
- Hits          901      899       -2     
- Misses        119      120       +1     
- Partials       53       54       +1     

Flag	Coverage Δ
e2e	61.60% <ø> (-0.23%)	⬇️
unit	80.34% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
internal/catalogmetadata/types.go	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[m1kola]

I don't think we need a pointer to a function here.

[m1kola]

So the issue is that we were setting SemverRange on a copy and not on the instance from requiredPackages.

I think we have the same issue in master here:

operator-controller/internal/resolution/entities/bundle_entity.go

Lines 234 to 240 in cdb99fa

	for _, requiredPackage := range requiredPackages {
	semverRange, err := bsemver.ParseRange(requiredPackage.VersionRange)
	if err != nil {
	return fmt.Errorf("error determining bundle required package semver range for entity '%s': '%w'", b.ID, err)
	}
	requiredPackage.SemverRange = &semverRange
	}

But I believe it is unused currently in master since we do parsing here anyway:

operator-controller/internal/resolution/variablesources/bundles_and_dependencies.go

Lines 90 to 93 in cdb99fa

	semverRange, err := bsemver.ParseRange(requiredPackage.VersionRange)
	if err != nil {
	return nil, err
	}

Not going to submit a PR for bundle_entity.go since it is going away as soon as #413 merges.

[perdasilva]

lgtm