Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make codecov wait for both jobs to upload coverage #441

Merged

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Oct 6, 2023

Description

Currently we have 2 jobs that report code coverage to codecov. This setting makes codecov to wait for both before sending notifications such as comments and pull request checks.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Currently we have 2 jobs that report code coverage to codecov.
This setting makes codecov to wait for both before sending
notifications such as comments and pull request checks.

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (65bfc69) 84.00% compared to head (83d8f24) 84.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #441   +/-   ##
=======================================
  Coverage   84.00%   84.00%           
=======================================
  Files          23       23           
  Lines         844      844           
=======================================
  Hits          709      709           
  Misses         93       93           
  Partials       42       42           
Flag Coverage Δ
e2e 66.11% <ø> (ø)
unit 76.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola m1kola marked this pull request as ready for review October 6, 2023 09:36
@m1kola m1kola requested a review from a team as a code owner October 6, 2023 09:36
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2023
@joelanford joelanford added this pull request to the merge queue Oct 6, 2023
Merged via the queue into operator-framework:main with commit e792902 Oct 6, 2023
11 checks passed
@m1kola m1kola deleted the codecov_notifications_tweak branch October 6, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants