Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add k8s.io/apimachinery/pkg/util/sets #462

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Add k8s.io/apimachinery/pkg/util/sets #462

merged 1 commit into from
Oct 16, 2023

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Oct 16, 2023 •
edited
Loading

Description

Switches from map of empty structs to using sets package from apimachinery utils.

Note: there is also internal/resolution/variablesources/crd_constraints.go which uses map for empty structs, but there is #461 which modifies this file and makes use of sets package.

Fixes #454

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@m1kola
Add k8s.io/apimachinery/pkg/util/sets
7c89b79 
Switches from `map` of empty structs to using
sets package from apimachinery utils.

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2023
@m1kola m1kola marked this pull request as ready for review October 16, 2023 10:25
@m1kola m1kola requested a review from a team as a code owner October 16, 2023 10:25
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e001a0f) 83.80% compared to head (7c89b79) 83.80%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #462   +/-   ##
=======================================
  Coverage   83.80%   83.80%           
=======================================
  Files          23       23           
  Lines         846      846           
=======================================
  Hits          709      709           
  Misses         94       94           
  Partials       43       43
Flag Coverage Δ
e2e 65.95% <66.66%> (ø)
unit 76.58% <77.77%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lution/variablesources/bundles_and_dependencies.go 96.00% <100.00%> (ø)
...al/resolution/variablesources/bundle_deployment.go 72.72% <66.66%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

stevekuznetsov
stevekuznetsov approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023
@stevekuznetsov stevekuznetsov added this pull request to the merge queue Oct 16, 2023
Merged via the queue into operator-framework:main with commit 7161a7b Oct 16, 2023
12 checks passed
@m1kola m1kola deleted the sets branch October 16, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov approved these changes

Assignees

@stevekuznetsov stevekuznetsov

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider using k8s.io/apimachinery/pkg/util/sets instead of map of empty structs for sets
2 participants
@m1kola @stevekuznetsov