Fix filtering of successors bundles #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1kola
added
kind/bug
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
==========================================
- Coverage 83.64% 83.52% -0.12%
==========================================
Files 23 23
Lines 862 868 +6
==========================================
+ Hits 721 725 +4
- Misses 96 97 +1
- Partials 45 46 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
4 tasks
Previously we were not filtering bundles by package name. This could cause the code to select incorrect successors becuase we were only filtering all bundle by versions. With this change we make sure that we are selecting bundles from the same package. Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
|
Updated commit message to have a bit more details. |
Merged
via the queue into
operator-framework:main
with commit Oct 23, 2023
e9733c5
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #477
Reviewer Checklist