Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove unused test data #484

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Oct 24, 2023

Description

A bunch of test yaml are no longer used after #444 where we started re-tagging bundle images instead of building from scratch.

In this PR:

  • YAMLs from 0.65.1 moved into fake/test 1.0.0 version of prometheus-operator.
  • Rest of unused prometheus-operator YAMLs removed
  • Makefile updated to no longer build unused prometheus-operator test images

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2023
@m1kola
Copy link
Member Author

m1kola commented Oct 24, 2023

Will keep it in draft for now. I think I broke something.

Edit: Updated. I incorrectly updated Makefile initially. All fixed now.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2023
@ncdc ncdc changed the title Remove unused test data 🌱 Remove unused test data Nov 6, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e07bea0) 84.45% compared to head (185a570) 84.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #484   +/-   ##
=======================================
  Coverage   84.45%   84.45%           
=======================================
  Files          23       23           
  Lines         907      907           
=======================================
  Hits          766      766           
  Misses         96       96           
  Partials       45       45           
Flag Coverage Δ
e2e 65.93% <ø> (ø)
unit 79.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola m1kola marked this pull request as ready for review November 7, 2023 14:20
@m1kola m1kola requested a review from a team as a code owner November 7, 2023 14:20
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2023
@m1kola m1kola enabled auto-merge November 7, 2023 14:29
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola
Copy link
Member Author

m1kola commented Nov 7, 2023

Rebasd on top of main again just in case.

Copy link
Contributor

@dtfranz dtfranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@m1kola m1kola added this pull request to the merge queue Nov 7, 2023
Merged via the queue into operator-framework:main with commit e9fd250 Nov 7, 2023
14 checks passed
@m1kola m1kola deleted the clean-up-e2e-images branch November 7, 2023 16:20
@m1kola m1kola mentioned this pull request May 8, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants