Update E2E test data to fix operator-developer-e2e
#488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Note: with the current state of This PR just focuses on updating the data. |
Zero major version is reserved for initial development according to SemVer spec[^1] and anything may change at any time. Updates for this version behaves differently: * When version is `0.1.0` we allow versions which are >= `0.1.0` and < `0.2.0` (patch updates) * When version is `0.0.1` we allow versions which are >= `0.0.1` and < `0.0.2` (no updates) To be able to update in the second case (e.g. from `0.0.1` to `0.0.2`) users will have to set `.spec.upgradeConstraintPolicy` to `Ignore` once support for this implemented. We have unit tests for the above behaviour, but E2E test data was not updated. [^1]: https://semver.org/#spec-item-4 Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
m1kola
force-pushed
the
update_operator-developer-e2e_test_data
branch
from
f34bf55
to
3d50312
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
This was referenced Oct 24, 2023
|
So, just going to ignore 0.x.x for now? |
In E2E - yes. But we have tests for this here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zero major version is reserved for initial development according to SemVer spec1 and anything may change at any time.
Updates for this version behaves differently:
0.1.0we allow versions which are >=0.1.0and <0.2.0(patch updates)0.0.1we allow versions which are >=0.0.1and <0.0.2(no updates)To be able to update in the second case (e.g. from
0.0.1to0.0.2) users will have to set.spec.upgradeConstraintPolicytoIgnoreonce support for this implemented.We have unit tests for the above behaviour, but E2E test data was not updated.
Fixes #481
Description
Reviewer Checklist
Footnotes
https://semver.org/#spec-item-4 ↩