Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove offline resolution CLI variable source #495

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Remove offline resolution CLI variable source #495

merged 1 commit into from
Nov 1, 2023

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Oct 31, 2023

Description

Spliting #460 into smaller chunks. Related to #437

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2023
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7156464) 83.75% compared to head (432c2f7) 83.75%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #495   +/-   ##
=======================================
  Coverage   83.75%   83.75%           
=======================================
  Files          23       23           
  Lines         868      868           
=======================================
  Hits          727      727           
  Misses         96       96           
  Partials       45       45
Flag Coverage Δ
e2e 65.09% <ø> (ø)
unit 78.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola m1kola marked this pull request as ready for review October 31, 2023 14:23
@m1kola m1kola requested a review from a team as a code owner October 31, 2023 14:23
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2023
This was referenced Oct 31, 2023
Merged
Merged
Closed
stevekuznetsov
stevekuznetsov reviewed Oct 31, 2023
View reviewed changes
cmd/resolutioncli/main.go
@@ -22,8 +22,7 @@ import (
"fmt"
"os"

"github.com/operator-framework/deppy/pkg/deppy/solver"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: likely good to use an import sorting linter to remove these diffs in the future

@m1kola
Remove offline resolution CLI variable source
432c2f7 
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola m1kola force-pushed the remove_offline_resolution_variable_source branch from fd9e75d to 432c2f7 Compare October 31, 2023 17:11
@m1kola
Copy link
Member Author

m1kola commented Nov 1, 2023

@stevekuznetsov I see that you enabled auto merge yesterday. Did you also mean to approve it? Or do you have further feedback?

@stevekuznetsov
Copy link
Member

Sorry, all the repos have different rules for merging and it's too easy to do the wrong dance ...

stevekuznetsov
stevekuznetsov approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d

@stevekuznetsov stevekuznetsov added this pull request to the merge queue Nov 1, 2023
@m1kola
Copy link
Member Author

m1kola commented Nov 1, 2023

Sorry, all the repos have different rules for merging and it's too easy to do the wrong dance ...

No worries! Thanks for the update!

Merged via the queue into operator-framework:main with commit 7411e68 Nov 1, 2023
12 checks passed
@m1kola m1kola deleted the remove_offline_resolution_variable_source branch November 6, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m1kola @stevekuznetsov