Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 use correct context for catalog watch handler #516

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

joelanford
Copy link
Member

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford requested a review from a team as a code owner November 6, 2023 14:59
@ncdc ncdc changed the title fix: use correct context for catalog watch handler 🐛 use correct context for catalog watch handler Nov 6, 2023
@ncdc ncdc enabled auto-merge November 6, 2023 15:03
@ncdc ncdc added this pull request to the merge queue Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f61f6d) 84.41% compared to head (24a5097) 84.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   84.41%   84.19%   -0.23%     
==========================================
  Files          23       23              
  Lines         892      892              
==========================================
- Hits          753      751       -2     
- Misses         95       96       +1     
- Partials       44       45       +1     
Flag Coverage Δ
e2e 65.69% <100.00%> (-0.23%) ⬇️
unit 79.54% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/controllers/operator_controller.go 80.00% <100.00%> (-0.82%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into operator-framework:main with commit 55d54ab Nov 6, 2023
11 of 12 checks passed
@joelanford joelanford deleted the small-fix-watches branch November 6, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants