Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 PRs: use icons in descriptions #517

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Nov 6, 2023

Description

Update PR template to provide guidance on title icons.

Add job to verify icon in PR title.

Make sure dependabot PRs titles are prefixed with 🌱.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Update PR template to provide guidance on title icons.

Add job to verify icon in PR title.

Make sure dependabot PRs titles are prefixed with 🌱.

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
@ncdc ncdc requested a review from a team as a code owner November 6, 2023 15:19
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7411e68) 83.75% compared to head (a0d67c6) 84.19%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
+ Coverage   83.75%   84.19%   +0.43%     
==========================================
  Files          23       23              
  Lines         868      892      +24     
==========================================
+ Hits          727      751      +24     
  Misses         96       96              
  Partials       45       45              
Flag Coverage Δ
e2e 65.69% <ø> (+0.60%) ⬆️
unit 79.54% <ø> (+1.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelanford joelanford added this pull request to the merge queue Nov 6, 2023
Merged via the queue into operator-framework:main with commit 216a1b2 Nov 6, 2023
11 checks passed
@ncdc ncdc deleted the pr-titles branch November 6, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants