Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Respect upgrade constraint policy set on Operator #520

Merged
merged 1 commit into from
Nov 7, 2023
Merged

✨ Respect upgrade constraint policy set on Operator #520

merged 1 commit into from
Nov 7, 2023

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Nov 6, 2023 •
edited
Loading

Description

Closes #449

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2023
@m1kola m1kola changed the title ✨ Add upgrade constraint policy ✨ Respect upgrade constraint policy set on Operator Nov 6, 2023
@m1kola m1kola force-pushed the add_upgradeConstraintPolicy branch 2 times, most recently from 5b9e713 to f1d4d8e Compare November 6, 2023 16:50
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 6, 2023
@m1kola m1kola force-pushed the add_upgradeConstraintPolicy branch from f1d4d8e to c7c44e6 Compare November 7, 2023 10:10
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2023 •
edited
Loading

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (69db2ad) 84.41% compared to head (2dea4fc) 84.45%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
+ Coverage   84.41%   84.45%   +0.03%     
==========================================
  Files          23       23              
  Lines         892      907      +15     
==========================================
+ Hits          753      766      +13     
- Misses         95       96       +1     
- Partials       44       45       +1
Flag Coverage Δ
e2e 65.93% <65.30%> (+0.01%) ⬆️
unit 79.43% <73.46%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/controllers/variable_source.go 72.72% <100.00%> (ø)
...al/resolution/variablesources/bundle_deployment.go 100.00% <100.00%> (+21.05%) ⬆️
...al/resolution/variablesources/installed_package.go 71.42% <71.05%> (-2.49%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola m1kola force-pushed the add_upgradeConstraintPolicy branch from c7c44e6 to 7c27170 Compare November 7, 2023 11:12
@m1kola
Respect .spec.upgradeConstraintPolicy
2dea4fc 
This commit makes OLM respect `.spec.upgradeConstraintPolicy`
set on an `Operator` CR when chosing upgrade edges.

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola m1kola force-pushed the add_upgradeConstraintPolicy branch from 7c27170 to 2dea4fc Compare November 7, 2023 11:54
@m1kola m1kola marked this pull request as ready for review November 7, 2023 12:03
@m1kola m1kola requested a review from a team as a code owner November 7, 2023 12:03
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2023
This was referenced Nov 7, 2023
Closed
Closed
@m1kola m1kola added this pull request to the merge queue Nov 7, 2023
Merged via the queue into operator-framework:main with commit 8c59a33 Nov 7, 2023
15 of 16 checks passed
@m1kola m1kola deleted the add_upgradeConstraintPolicy branch November 7, 2023 14:05
@m1kola m1kola mentioned this pull request Nov 7, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Respect .spec.upgradeConstraintPolicy
3 participants
@m1kola @joelanford @openshift-merge-robot