Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 update catalog status field being used for stale cache identification #529

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

everettraven
Copy link
Contributor

@everettraven everettraven commented Nov 8, 2023

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

…tification

Signed-off-by: Bryce Palmer <everettraven@gmail.com>
@everettraven everettraven requested a review from a team as a code owner November 8, 2023 22:10
@everettraven everettraven changed the title 🐛 update catalog status field being used for stale cache iden… 🐛 update catalog status field being used for stale cache identification Nov 8, 2023
Signed-off-by: Bryce Palmer <everettraven@gmail.com>
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b5c6bc9) 84.45% compared to head (8a4fc1f) 84.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #529   +/-   ##
=======================================
  Coverage   84.45%   84.45%           
=======================================
  Files          23       23           
  Lines         907      907           
=======================================
  Hits          766      766           
  Misses         96       96           
  Partials       45       45           
Flag Coverage Δ
e2e 65.93% <100.00%> (ø)
unit 79.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/catalogmetadata/cache/cache.go 70.21% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola m1kola added this pull request to the merge queue Nov 9, 2023
Merged via the queue into operator-framework:main with commit bf39dc7 Nov 9, 2023
15 checks passed
@m1kola m1kola mentioned this pull request Sep 2, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Catalog cache doesn't update when the Catalog changes
2 participants