Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Remove dependency between tests and prevent cascading failures #534

Merged

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Nov 9, 2023

Description

This removes dependency between tests and prevents cascading failures

Closes #512

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

This removes dependency between tests and prevents cascading failures

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 9, 2023
@m1kola m1kola changed the title Remove dependency between tests and prevents cascading failures 🐛 Remove dependency between tests and prevents cascading failures Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf39dc7) 84.45% compared to head (56d8ab6) 84.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #534   +/-   ##
=======================================
  Coverage   84.45%   84.45%           
=======================================
  Files          23       23           
  Lines         907      907           
=======================================
  Hits          766      766           
  Misses         96       96           
  Partials       45       45           
Flag Coverage Δ
e2e 65.93% <ø> (ø)
unit 79.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola m1kola marked this pull request as ready for review November 9, 2023 15:39
@m1kola m1kola requested a review from a team as a code owner November 9, 2023 15:39
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 9, 2023
@m1kola m1kola changed the title 🐛 Remove dependency between tests and prevents cascading failures 🐛 Remove dependency between tests and prevent cascading failures Nov 10, 2023
@m1kola m1kola added this pull request to the merge queue Nov 10, 2023
Merged via the queue into operator-framework:main with commit f95ef47 Nov 10, 2023
15 of 16 checks passed
@m1kola m1kola deleted the gh512_refactor-test-catalog-setup branch November 10, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies between e2e tests lead to cascading failures
2 participants