Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove prettyUnsatMessage workaround #547

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Nov 17, 2023

Description

It was a workaround a Deppy issue. We no longer need it since Deppy fixed the issue.

Related Deppy issues:

Closes #459

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2023
@m1kola m1kola force-pushed the remove_prettyUnsatMessage branch 4 times, most recently from dd72e49 to 2419537 Compare November 17, 2023 10:28
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a250a9b) 83.69% compared to head (e468ee4) 83.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
+ Coverage   83.69%   83.72%   +0.02%     
==========================================
  Files          20       20              
  Lines         822      811      -11     
==========================================
- Hits          688      679       -9     
+ Misses         92       91       -1     
+ Partials       42       41       -1     
Flag Coverage Δ
e2e 63.62% <100.00%> (-0.25%) ⬇️
unit 78.54% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola m1kola changed the title 🌱 Remove pretty unsat message 🌱 Remove prettyUnsatMessage workaround Nov 17, 2023
It was a workaround a Deppy issue. We no longer need it
since Deppy fixed the issue.

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola m1kola marked this pull request as ready for review November 17, 2023 14:23
@m1kola m1kola requested a review from a team as a code owner November 17, 2023 14:23
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2023
@m1kola m1kola added this pull request to the merge queue Nov 17, 2023
Merged via the queue into operator-framework:main with commit 2105d1a Nov 17, 2023
15 checks passed
@m1kola m1kola deleted the remove_prettyUnsatMessage branch November 17, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolution error message is not deterministic
2 participants