-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠ rename Operator API to ClusterExtension API #568
⚠ rename Operator API to ClusterExtension API #568
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #568 +/- ##
=======================================
Coverage 83.60% 83.60%
=======================================
Files 20 20
Lines 811 811
=======================================
Hits 678 678
Misses 92 92
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
676c73e
to
e3be862
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Left a couple comments on more nitpicky things, so feel free to address them or ignore them - totally up to you.
e3be862
to
5ba4505
Compare
5ba4505
to
603cab5
Compare
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
603cab5
to
cd8b3b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9316012
Description
This PR updates the
Operator
API to be renamed toClusterExtension
, and updates docs terminology, variable names, etc. to align with the more generic "extension" term. This helps in a variety of ways:Operator
APIs in both OLMv0 and OLMv1 in different groups, which causes UX problems with thekubectl <verb> operators
.Cluster
prefix paves the way to introducing a namespace-scoped equivalentExtension
API.Reviewer Checklist