🌱 bump controller-runtime to 0.16 #573
Conversation
| @@ -84,8 +84,7 @@ func main() { | |||
|
|
|||
| mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{ | |||
| Scheme: scheme, | |||
| MetricsBindAddress: metricsAddr, | |||
| Port: 9443, | |||
There was a problem hiding this comment.
This is:
- the webhook port (we don't have any webhooks)
- defaulted to
9443anyway, even if we did have webhooks.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #573 +/- ##
==========================================
- Coverage 83.60% 83.58% -0.03%
==========================================
Files 20 20
Lines 811 810 -1
==========================================
- Hits 678 677 -1
Misses 92 92
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joelanford
force-pushed
the
k8s-cr-bump
branch
from
21b3e96
to
c8aa7ba
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@joelanford not sure if this needs a rebase and/or go mod tidy? |
also bump patch version of kubernetes to 0.28.5 Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
force-pushed
the
k8s-cr-bump
branch
from
c8aa7ba
to
42da79b
Compare
|
Looks like the operator-registry bump meant I needed rebase+go mod tidy. Hopefully good again now. |
| @@ -84,8 +84,7 @@ func main() { | |||
|
|
|||
| mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{ | |||
| Scheme: scheme, | |||
| MetricsBindAddress: metricsAddr, | |||
| Port: 9443, | |||
| Metrics: server.Options{BindAddress: metricsAddr}, | |||
There was a problem hiding this comment.
Nice to have for performance evaluations would be to add a flag that sets the pprof endpoint to enable/disable the default pprof implementation through controller-runtime. Could be done in a follow-up though and shouldn't hold this PR
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
also bump patch version of kubernetes to 0.28.5
Description
Reviewer Checklist