Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: extension controller should requeue extensions when catalogs change #643

Merged

Conversation

joelanford
Copy link
Member

Description

There is a bug in the watch setup of the extension controller where watch events for catalog updates are translated to reconcile requests that bear the name of the catalog, which means it is trying to reconcile an Extension with the same name as the catalog that evented.

This isn't the intention. The intention is to requeue all Extensions when a catalog changes, since that might mean a new/better version is available for us to consume.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford requested a review from a team as a code owner February 21, 2024 19:55
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (d51dfe6) 84.53% compared to head (1cbab3b) 76.40%.
Report is 22 commits behind head on main.

Files Patch % Lines
internal/controllers/extension_controller.go 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #643      +/-   ##
==========================================
- Coverage   84.53%   76.40%   -8.13%     
==========================================
  Files          20       24       +4     
  Lines         931     1208     +277     
==========================================
+ Hits          787      923     +136     
- Misses        100      234     +134     
- Partials       44       51       +7     
Flag Coverage Δ
e2e 53.64% <0.00%> (-6.19%) ⬇️
unit 70.57% <0.00%> (-9.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelanford joelanford added this pull request to the merge queue Feb 21, 2024
Merged via the queue into operator-framework:main with commit 6fa2685 Feb 21, 2024
13 of 15 checks passed
@joelanford joelanford deleted the extension-catalog-watches branch February 21, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants