Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ remove ExtensionInterface and related functions/implementations #644

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

joelanford
Copy link
Member

Description

Closes #634

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford requested a review from a team as a code owner February 21, 2024 21:53
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d51dfe6) 84.53% compared to head (fdcffc6) 78.90%.
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
- Coverage   84.53%   78.90%   -5.64%     
==========================================
  Files          20       22       +2     
  Lines         931     1147     +216     
==========================================
+ Hits          787      905     +118     
- Misses        100      192      +92     
- Partials       44       50       +6     
Flag Coverage Δ
e2e 55.71% <ø> (-4.12%) ⬇️
unit 72.89% <ø> (-7.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love removing code! :)

@m1kola m1kola added this pull request to the merge queue Feb 22, 2024
Merged via the queue into operator-framework:main with commit eb412ba Feb 22, 2024
13 of 15 checks passed
@joelanford joelanford deleted the rm-extension-iface branch February 22, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow-up(add extension API): Remove ExtensionInterface and related functions/implementations
2 participants