🐛 [Fix] fix hasKappAPIs method #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method was listing resources falling under the `kappctrl.k14s.io` string. It would return nil when kapp-ctrl is not installed, resulting in a panic. Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
==========================================
- Coverage 64.10% 64.01% -0.10%
==========================================
Files 22 22
Lines 1368 1370 +2
==========================================
Hits 877 877
- Misses 441 442 +1
- Partials 50 51 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kevinrizza
approved these changes
Mar 4, 2024
Merged
via the queue into
operator-framework:main
with commit Mar 4, 2024
d10056e
11 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method was listing resources falling under the
kappctrl.k14s.iostring. It would return nil when kapp-ctrl is not installed, resulting in a panic.Description
Reviewer Checklist