Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Source Makefile kapp version from go.mod #705

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

dtfranz
Copy link
Contributor

@dtfranz dtfranz commented Mar 19, 2024

Grabs the kapp version from what we are currently using in go.mod in order to ensure parity.

Grabs the kapp version from what we are currently using in go.mod in order to ensure parity.

Signed-off-by: dtfranz <dfranz@redhat.com>
@dtfranz dtfranz requested a review from a team as a code owner March 19, 2024 17:18
Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit fe37a24
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/65f9c8f329a33b00073a457d
😎 Deploy Preview https://deploy-preview-705--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.01%. Comparing base (9f6e7df) to head (fe37a24).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #705   +/-   ##
=======================================
  Coverage   64.01%   64.01%           
=======================================
  Files          22       22           
  Lines        1370     1370           
=======================================
  Hits          877      877           
  Misses        442      442           
  Partials       51       51           
Flag Coverage Δ
e2e 47.37% <ø> (ø)
unit 58.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ankitathomas ankitathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
@dtfranz dtfranz added this pull request to the merge queue Mar 20, 2024
Merged via the queue into operator-framework:main with commit 59ec861 Mar 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants