Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Fix jq codeblocks #728

Conversation

michaelryanpeter
Copy link
Contributor

@michaelryanpeter michaelryanpeter commented Apr 1, 2024

Description

Closes #698

Preview links

  • Catalog queries (better formatting and the copy button at the end of the code block)
  • Finding extensions to install (fix typos)

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Improve the formatting of the code blocks in the catalog queries
description list
@michaelryanpeter michaelryanpeter requested a review from a team as a code owner April 1, 2024 18:31
Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 083a09b
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/660afd7b9015e70008b85a4b
😎 Deploy Preview https://deploy-preview-728--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.50%. Comparing base (d9b51d6) to head (083a09b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #728   +/-   ##
=======================================
  Coverage   63.50%   63.50%           
=======================================
  Files          22       22           
  Lines        1403     1403           
=======================================
  Hits          891      891           
  Misses        459      459           
  Partials       53       53           
Flag Coverage Δ
e2e 47.25% <ø> (ø)
unit 57.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grokspawn grokspawn changed the title 📖 Fix jq codeblocks (Issue #698) 📖 Fix jq codeblocks Apr 1, 2024
@grokspawn grokspawn changed the title 📖 Fix jq codeblocks 📖 Fix jq codeblocks Apr 1, 2024
@grokspawn grokspawn added this pull request to the merge queue Apr 1, 2024
Merged via the queue into operator-framework:main with commit 8127270 Apr 1, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Fix jq examples on "Catalog queries" page
2 participants