✨ Import grouping linter changes #748
Conversation
golangci-lint will now group imports in the following order: - standard library - 3rd party packages outside of our Github org - packages from our Github org - local imports from operator-controller Signed-off-by: Tayler Geiger <tayler@redhat.com>
All imports should now be properly ordered according to the gci group import rules. Signed-off-by: Tayler Geiger <tayler@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #748 +/- ##
=======================================
Coverage 63.81% 63.81%
=======================================
Files 22 22
Lines 1415 1415
=======================================
Hits 903 903
Misses 459 459
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| - standard | ||
| - default | ||
| - prefix(github.com/operator-framework) | ||
| - prefix(github.com/operator-framework/operator-controller) |
There was a problem hiding this comment.
What do you think about using localmodule for implicitly handling the imports from the same module?
| - prefix(github.com/operator-framework/operator-controller) | |
| - localmodule |
There was a problem hiding this comment.
That's a good idea, I'll throw up another small PR soon.
There was a problem hiding this comment.
Would we want dot or alias groups?
There was a problem hiding this comment.
I would say we do not need a separate group for those.
I would even consider disallowing dot imports.
There was a problem hiding this comment.
Looks like the localmodule section in gci hasn't hit golangci-lint yet
Description
This PR enables the gci linter in golangci-lint and adds configuration to group imports as follows:
Closes #510
Reviewer Checklist