Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ : updating controller-tools to v0.14.0 #751

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

acornett21
Copy link
Contributor

@acornett21 acornett21 commented Apr 11, 2024

Description

Updating controller-tools to v0.14.0 to enable developers with go 1.22 to more easily work on this project.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Adam D. Cornett <adc@redhat.com>
@acornett21 acornett21 requested a review from a team as a code owner April 11, 2024 22:53
Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit b35a891
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/661869d600cb0200084ad549
😎 Deploy Preview https://deploy-preview-751--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.15%. Comparing base (ea567f9) to head (b35a891).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
+ Coverage   63.81%   68.15%   +4.34%     
==========================================
  Files          22       22              
  Lines        1415     1429      +14     
==========================================
+ Hits          903      974      +71     
+ Misses        459      390      -69     
- Partials       53       65      +12     
Flag Coverage Δ
e2e 46.18% <ø> (-1.03%) ⬇️
unit 62.23% <ø> (+4.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acmenezes
Copy link
Contributor

@acornett21, I just opened an issue #754 for this one. Actually go 1.20 seems to break as well. I tested your update and it works well.

Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2024
@tmshort tmshort added this pull request to the merge queue Apr 15, 2024
Merged via the queue into operator-framework:main with commit b8286ed Apr 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make run doesn't work with go 1.22 or 1.21 and go1.20 is also breaking due to incompatible directive in go.mod
4 participants