Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add ValidatingAdmissionPolicy to enforce package uniqueness across ClusterExtension #774

Merged
merged 2 commits into from
Apr 24, 2024
Merged

✨ Add ValidatingAdmissionPolicy to enforce package uniqueness across ClusterExtension #774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
145a376
Add `ValidatingAdmissionPolicy`
m1kola Apr 22, 2024
e59ab41
Kustomize `ValidatingAdmissionPolicyBinding`
m1kola Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions config/admission/admission.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
apiVersion: admissionregistration.k8s.io/v1beta1
kind: ValidatingAdmissionPolicy
metadata:
name: "clusterextensions-package-uniqueness"
spec:
failurePolicy: Fail
paramKind:
apiVersion: olm.operatorframework.io/v1alpha1
kind: ClusterExtension
matchConstraints:
resourceRules:
- apiGroups: ["olm.operatorframework.io"]
apiVersions: ["v1alpha1"]
operations: ["CREATE", "UPDATE"]
resources: ["clusterextensions"]
matchConditions:
# Only apply the policy when the request operation is CREATE
# or when the package is being changed
- name: 'only-create-or-package-change'
expression: request.operation == 'CREATE' || oldObject.spec.packageName != object.spec.packageName
validations:
- expression: object.spec.packageName != params.spec.packageName
messageExpression: "'Package \"' + string(object.spec.packageName) + '\" is already installed via ClusterExtension \"' + string(params.metadata.name) + '\"'"
reason: Invalid

---

apiVersion: admissionregistration.k8s.io/v1beta1
kind: ValidatingAdmissionPolicyBinding
metadata:
name: "clusterextensions-package-uniqueness-binding"
spec:
policyName: "clusterextensions-package-uniqueness"
validationActions: [Deny]
paramRef:
parameterNotFoundAction: Allow
selector: {}
5 changes: 5 additions & 0 deletions config/admission/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
configurations:
- kustomizeconfig.yaml

resources:
- admission.yaml
9 changes: 9 additions & 0 deletions config/admission/kustomizeconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# This file is for teaching kustomize how to substitute name in ValidatingAdmissionPolicyBinding
# This might become obsolete depending on the outcome of https://github.com/kubernetes-sigs/kustomize/issues/5674
nameReference:
- kind: ValidatingAdmissionPolicy
group: admissionregistration.k8s.io
fieldSpecs:
- kind: ValidatingAdmissionPolicyBinding
group: admissionregistration.k8s.io
path: spec/policyName
1 change: 1 addition & 0 deletions config/default/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ namePrefix: operator-controller-

resources:
- ../crd
- ../admission
- ../rbac
- ../manager
# [WEBHOOK] To enable webhook, uncomment all the sections with [WEBHOOK] prefix including the one in
Expand Down
Loading