Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Disallow bundles with dependencies and constraints #781

Merged
merged 1 commit into from
May 2, 2024

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Apr 24, 2024

Description

Draft for the changes proposed in this doc: disallowing registry+v1 bundles with dependencies.

Closes #779

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2024
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 4813cd3
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6633a8b4bbce9600085e3f66
😎 Deploy Preview https://deploy-preview-781--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.64%. Comparing base (e32aa27) to head (4813cd3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
+ Coverage   64.15%   64.64%   +0.48%     
==========================================
  Files          16       16              
  Lines        1303     1321      +18     
==========================================
+ Hits          836      854      +18     
  Misses        404      404              
  Partials       63       63              
Flag Coverage Δ
e2e 41.86% <44.44%> (+0.03%) ⬆️
unit 57.56% <100.00%> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grokspawn
Copy link
Contributor

closes #734

@m1kola m1kola force-pushed the regestryv1_validations branch 4 times, most recently from f5697b5 to 46cfcb5 Compare May 2, 2024 09:36
@m1kola m1kola marked this pull request as ready for review May 2, 2024 10:00
@m1kola m1kola requested a review from a team as a code owner May 2, 2024 10:00
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2024
@m1kola m1kola requested a review from grokspawn May 2, 2024 10:00
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@grokspawn grokspawn added this pull request to the merge queue May 2, 2024
Merged via the queue into operator-framework:main with commit f22ce65 May 2, 2024
17 checks passed
@m1kola m1kola deleted the regestryv1_validations branch May 2, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail installation attempts for registry+v1 bundles with expressed dependencies
3 participants