🐛 Use bin-dir override on setup_envtest #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #790 +/- ##
=======================================
Coverage 67.16% 67.16%
=======================================
Files 22 22
Lines 1465 1465
=======================================
Hits 984 984
Misses 415 415
Partials 66 66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4 tasks
Rather than change XDG_DATA_HOME, since many distributions do not explicitly define XDG_DATA_HOME but rather fallback to the default, check if XDG_DATA_HOME is not set and if HOME is either not set or set to the root filesystem. If so, override the setup_envtest binary directory. This helps prevent errors on some CI/CD environments. Signed-off-by: Tayler Geiger <tayler@redhat.com>
joelanford
approved these changes
Apr 26, 2024
|
Thanks! |
trgeiger
added a commit
to trgeiger/catalogd
that referenced
this pull request
May 7, 2024
This mirrors the same fix made previously in operator-controller: operator-framework/operator-controller#790 Signed-off-by: Tayler Geiger <tayler@redhat.com>
github-merge-queue bot
pushed a commit
to operator-framework/catalogd
that referenced
this pull request
May 23, 2024
This mirrors the same fix made previously in operator-controller: operator-framework/operator-controller#790 Signed-off-by: Tayler Geiger <tayler@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than change XDG_DATA_HOME, since many distributions do not explicitly define XDG_DATA_HOME but rather fallback to the default, use a new optional variable SETUP_ENVTEST_BIN_DIR to override the setup_envtest binary directory.
Setting XDG_DATA_HOME in the Makefile was breaking the kind cluster setup on Fedora which just uses the default fallback value for XDG_DATA_HOME.
Description
Reviewer Checklist