Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump mkdocs to 1.6.0 and mkdocs-material to 9.5.19 #796

Merged
merged 1 commit into from
Apr 29, 2024
Merged

🌱 Bump mkdocs to 1.6.0 and mkdocs-material to 9.5.19 #796

merged 1 commit into from
Apr 29, 2024

Conversation

perdasilva
Copy link
Contributor

Description

Merges dependabot PRs: #787 and #773

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

bump mkdocs and mkdocs-material docs dependencies
bf581ca 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva requested a review from a team as a code owner April 29, 2024 08:05
@netlify Netlify
Copy link

netlify bot commented Apr 29, 2024 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit bf581ca
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/662f54b5e3a4510008c7928f
😎 Deploy Preview https://deploy-preview-796--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This was referenced Apr 29, 2024
Closed
Closed
@codecov Codecov
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.21%. Comparing base (4876f78) to head (bf581ca).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #796   +/-   ##
=======================================
  Coverage   67.21%   67.21%           
=======================================
  Files          23       23           
  Lines        1467     1467           
=======================================
  Hits          986      986           
  Misses        415      415           
  Partials       66       66
Flag Coverage Δ
e2e 45.53% <ø> (ø)
unit 61.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

m1kola
m1kola reviewed Apr 29, 2024
View reviewed changes
requirements.txt
@@ -1 +1 @@
mkdocs-material==9.5.18
mkdocs-material==9.5.19
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need requirements.txt in root? With a quick grep I do not see how it is used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#694

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it looks like a partial duplicate of docs/requirements.txt. I think we can get rid of duplicated requirements by adding base = "docs" into netlify.toml.

I think I'm ok with merging this PR as is as it is not in scope for dependency bump.

@grokspawn grokspawn added this pull request to the merge queue Apr 29, 2024
Merged via the queue into operator-framework:main with commit 0fbb3e5 Apr 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1kola m1kola m1kola left review comments

@grokspawn grokspawn grokspawn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@perdasilva @m1kola @grokspawn